Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@
<YarpNugetVersion>2.3.0</YarpNugetVersion>
<MicrosoftExtensionsServiceDiscovery>9.1.0</MicrosoftExtensionsServiceDiscovery>
<MicrosoftExtensionsServiceDiscoveryYarp>9.1.0</MicrosoftExtensionsServiceDiscoveryYarp>
<OpenTelemetryExporterOpenTelemetryProtocol>1.9.0 </OpenTelemetryExporterOpenTelemetryProtocol>
<OpenTelemetryExtensionsHosting>1.9.0</OpenTelemetryExtensionsHosting>
<OpenTelemetryInstrumentationAspNetCore>1.9.0</OpenTelemetryInstrumentationAspNetCore>
<OpenTelemetryInstrumentationHttp>1.9.0</OpenTelemetryInstrumentationHttp>
<OpenTelemetryInstrumentationRuntime>1.9.0</OpenTelemetryInstrumentationRuntime>
<OpenTelemetryExporterOpenTelemetryProtocol>1.12.0 </OpenTelemetryExporterOpenTelemetryProtocol>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an FYI -

since Yarp.Application still targets net8.0, referencing these newer versions of OpenTelemetry will lift a bunch of libraries to the 9.0 versions. See open-telemetry/opentelemetry-dotnet#5973 for more information.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I forgot that we still build for .net8, I will remove the target in another PR. For the container we use .net9 anyway

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a space here, I guess somewhere there's a Version.Parse or something working anyway...

<OpenTelemetryExtensionsHosting>1.12.0</OpenTelemetryExtensionsHosting>
<OpenTelemetryInstrumentationAspNetCore>1.12.0</OpenTelemetryInstrumentationAspNetCore>
<OpenTelemetryInstrumentationHttp>1.12.0</OpenTelemetryInstrumentationHttp>
<OpenTelemetryInstrumentationRuntime>1.12.0</OpenTelemetryInstrumentationRuntime>
<AspNetCoreHealthChecksApplicationStatus>9.0.0</AspNetCoreHealthChecksApplicationStatus>
</PropertyGroup>
</Project>
Loading