Implement metrics #42

eventhorizon-cli · 2025-03-17T14:38:17Z

No description provided.

Copilot

Pull Request Overview

This pull request implements metrics support by adding new extension methods for statistical calculations and enum descriptions, updating documentation for both Chinese and English quick-start guides, and enhancing the docker-compose configuration to include metrics storage using InfluxDB.

Added EnumerableExtensions for computing variance and standard deviation
Added EnumExtensions for retrieving enum descriptions with caching
Updated documentation and docker-compose.yml to integrate metrics support via InfluxDB and a newer Grafana version

Reviewed Changes

Copilot reviewed 164 out of 171 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/Mocha.Core/Extensions/EnumerableExtensions.cs	Provides new methods to calculate population variance and standard deviation from sequence data
src/Mocha.Core/Extensions/EnumExtensions.cs	Adds extension methods to handle enum descriptions with caching for performance optimization
docs/quick-start/docker-compose/quick-start.zh-CN.md	Updates Docker Compose instructions and asset paths for the Chinese quick-start guide
docs/quick-start/docker-compose/quick-start.en-US.md	Updates Docker Compose instructions and asset paths for the English quick-start guide
docker/docker-compose.yml	Introduces an InfluxDB service for metrics storage and updates service configurations and Grafana version

Files not reviewed (7)

Mocha.sln: Language not supported
docker/query/Dockerfile: Language not supported
scripts/mysql/init/metadata.sql: Language not supported
scripts/mysql/init/trace.sql: Language not supported
src/Mocha.Antlr4.Generated/Mocha.Antlr4.Generated.csproj: Language not supported
src/Mocha.Antlr4.Generated/PromoQL/PromQLLexer.g4: Language not supported
src/Mocha.Antlr4.Generated/PromoQL/PromQLParser.g4: Language not supported

Comments suppressed due to low confidence (1)

docker/docker-compose.yml:1

The removal of the 'version' field in the docker-compose file may lead to compatibility issues with certain Docker Compose versions; please verify that the updated file syntax is compatible with your deployment environment.

version: "3.8"

Copilot

Copilot reviewed 164 out of 171 changed files in this pull request and generated 1 comment.

Files not reviewed (7)

Mocha.sln: Language not supported
docker/query/Dockerfile: Language not supported
scripts/mysql/init/metadata.sql: Language not supported
scripts/mysql/init/trace.sql: Language not supported
src/Mocha.Antlr4.Generated/Mocha.Antlr4.Generated.csproj: Language not supported
src/Mocha.Antlr4.Generated/PromoQL/PromQLLexer.g4: Language not supported
src/Mocha.Antlr4.Generated/PromoQL/PromQLParser.g4: Language not supported

Copilot · 2025-04-07T12:51:46Z

src/Mocha.Core/Extensions/EnumerableExtensions.cs

+        }
+
+        var mean = sum / count;
+        return sumSq / count - mean * mean;


The variance calculation may produce a slightly negative result due to floating point rounding errors, which causes Math.Sqrt to return NaN. Consider using Math.Max(0, sumSq / count - mean * mean) to ensure a non-negative variance.

Suggested change

return sumSq / count - mean * mean;

return Math.Max(0, sumSq / count - mean * mean);

Copilot

Copilot reviewed 164 out of 171 changed files in this pull request and generated 1 comment.

Files not reviewed (7)

Mocha.sln: Language not supported
docker/query/Dockerfile: Language not supported
scripts/mysql/init/metadata.sql: Language not supported
scripts/mysql/init/trace.sql: Language not supported
src/Mocha.Antlr4.Generated/Mocha.Antlr4.Generated.csproj: Language not supported
src/Mocha.Antlr4.Generated/PromoQL/PromQLLexer.g4: Language not supported
src/Mocha.Antlr4.Generated/PromoQL/PromQLParser.g4: Language not supported

Comments suppressed due to low confidence (1)

docker/docker-compose.yml:22

The volume binding has changed from a single initialization file to a directory; please ensure that the entrypoint script is configured to process multiple initialization files if this change is intentional.

-      - ../scripts/mysql/init:/docker-entrypoint-initdb.d/

Copilot · 2025-04-07T13:00:02Z

src/Mocha.Core/Extensions/EnumerableExtensions.cs

+        var mean = sum / count;
+        return Math.Max(0, sumSq / count - mean * mean);


[nitpick] Clamping the variance to 0 using Math.Max may mask underlying numerical precision issues. Consider documenting the rationale or using a more numerically stable algorithm (e.g., Welford's algorithm) if high precision is required.

Suggested change

var mean = sum / count;

return Math.Max(0, sumSq / count - mean * mean);

return m2 / count;

codecov · 2025-05-16T11:36:27Z

Codecov Report

Attention: Patch coverage is 17.36018% with 1847 lines in your changes missing coverage. Please review.

Project coverage is 38.67%. Comparing base (8bdc420) to head (7a9fb4d).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../Mocha.Query/Prometheus/PromQL/Engine/Evaluator.cs	0.00%	543 Missing ⚠️
...s/Metrics/OTelToMochaMetricConversionExtensions.cs	0.00%	349 Missing ⚠️
.../Mocha.Query/Prometheus/PromQL/Engine/Functions.cs	0.00%	148 Missing ⚠️
...ery/Prometheus/Controllers/PrometheusController.cs	0.00%	122 Missing ⚠️
...aders/Prometheus/InfluxDBPrometheusMetricReader.cs	0.00%	109 Missing ⚠️
...cha.Query/Prometheus/PromQL/Engine/PromQLEngine.cs	0.00%	88 Missing ⚠️
...rc/Mocha.Query/Prometheus/PromQL/Ast/AstBuilder.cs	65.40%	61 Missing and 12 partials ⚠️
src/Mocha.Core/Storage/Prometheus/Labels.cs	8.33%	44 Missing ⚠️
src/Mocha.Query/Program.cs	0.00%	32 Missing ⚠️
...tadata/Readers/EFPrometheusMetricMetadataReader.cs	0.00%	28 Missing ⚠️
... and 45 more

❗ There is a different number of reports uploaded between BASE (8bdc420) and HEAD (7a9fb4d). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (8bdc420) HEAD (7a9fb4d)

2 1

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #42       +/-   ##
===========================================
- Coverage   91.64%   38.67%   -52.97%     
===========================================
  Files          51      123       +72     
  Lines         993     3294     +2301     
  Branches      107      449      +342     
===========================================
+ Hits          910     1274      +364     
- Misses         57     1971     +1914     
- Partials       26       49       +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…li/mocha into implement_metrics

eventhorizon-cli added 7 commits March 17, 2025 22:26

implement metrics

3812d08

fix tests

1356c26

remove build warning

f47dc7c

fix tests

710bd83

format

ec6c8c6

use Prometheus file header

0787fd0

add antlr4 generated file to gitignore

de80959

eventhorizon-cli requested a review from Copilot April 1, 2025 08:13

Copilot AI reviewed Apr 1, 2025

View reviewed changes

fix md

b1f21dc

eventhorizon-cli requested review from Copilot and liuhaoyang April 7, 2025 12:50

Copilot AI reviewed Apr 7, 2025

View reviewed changes

ensure a non-negative variance

a29c25a

eventhorizon-cli requested a review from Copilot April 7, 2025 12:59

Copilot AI reviewed Apr 7, 2025

View reviewed changes

liuhaoyang approved these changes May 16, 2025

View reviewed changes

eventhorizon-cli added 5 commits May 16, 2025 19:09

disable codecov check

dcba815

try update codecov.yml

21486e4

update codecov action version

2f849b5

try fix code cov

4383415

Update dotnet-build.yml

b602d58

eventhorizon-cli added 7 commits May 16, 2025 19:38

Merge branch 'implement_metrics' of https://github.com/eventhorizon-c…

e476f98

…li/mocha into implement_metrics

try disable codecov

e12e76c

try disable

92d2144

try disable

e1ddd21

try disable

04ce6dc

Update dotnet-build.yml

8ef3952

Update dotnet-build.yml

5747523

eventhorizon-cli added 2 commits May 16, 2025 20:21

remove useless config

64f4200

Merge branch 'implement_metrics' of https://github.com/eventhorizon-c…

7a9fb4d

…li/mocha into implement_metrics

liuhaoyang merged commit bf4edd5 into dotnetcore:main May 18, 2025
2 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement metrics #42

Implement metrics #42

Uh oh!

eventhorizon-cli commented Mar 17, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 7, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 7, 2025

Uh oh!

codecov bot commented May 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	return sumSq / count - mean * mean;
	return Math.Max(0, sumSq / count - mean * mean);

		var mean = sum / count;
		return Math.Max(0, sumSq / count - mean * mean);

	var mean = sum / count;
	return Math.Max(0, sumSq / count - mean * mean);
	return m2 / count;

Implement metrics #42

Implement metrics #42

Uh oh!

Conversation

eventhorizon-cli commented Mar 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented May 16, 2025 •

edited

Loading