Skip to content

Remove netstandard2.0;net40; #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JaBistDuNarrisch merged 2 commits into from
Oct 30, 2025
Merged

Remove netstandard2.0;net40; #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f57130
Allow also unsigned data types for identity column
Oct 30, 2025
e81bba5
Getting rid of netstandard2.0;net40;
Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Migrator/DotNetProjects.Migrator.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net40;net9.0</TargetFrameworks>
<TargetFrameworks>net9.0</TargetFrameworks>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<AssemblyName>DotNetProjects.Migrator</AssemblyName>
<RootNamespace>DotNetProjects.Migrator</RootNamespace>
Expand Down
7 changes: 5 additions & 2 deletions src/Migrator/Providers/Impl/Oracle/OracleTransformationProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,11 +891,14 @@ public override void AddTable(string name, params IDbField[] fields)
{
var identityColumn = columns.First(x => x.ColumnProperty.HasFlag(ColumnProperty.Identity) && x.ColumnProperty.HasFlag(ColumnProperty.PrimaryKey));

List<DbType> allowedIdentityDbTypes = [DbType.Int16, DbType.Int32, DbType.Int64];
List<DbType> allowedIdentityDbTypes = [DbType.Int16, DbType.Int32, DbType.Int64, DbType.UInt16, DbType.UInt32, DbType.UInt64];

if (!allowedIdentityDbTypes.Contains(identityColumn.Type))
{
throw new MigrationException($"Identity columns can only be used with {nameof(DbType.Int16)}, {nameof(DbType.Int32)} and {nameof(DbType.Int64)}");
var allowedIdentityDbTypesStringList = allowedIdentityDbTypes.Select(x => x.ToString()).ToList();
var allowedIdentityDbTypesString = $"{string.Join(", ", allowedIdentityDbTypesStringList[..^1])} and {allowedIdentityDbTypesStringList[^1..]}";

throw new MigrationException($"Identity columns can only be used with {allowedIdentityDbTypesString}");
}

var identityColumnNameQuoted = QuoteColumnNameIfRequired(identityColumn.Name);
Expand Down
Loading