Skip to content

fix: missing fallback icon to failed service images #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dottmp merged 2 commits into from
Apr 6, 2026
Merged

fix: missing fallback icon to failed service images #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cc527e
rename fallback icon
dottmp Apr 6, 2026
5f2349a
add fallback icon to failed images
dottmp Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/components/icons/icons.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@
social: UsersRound,
media: Film,
creativity: Paintbrush,
categoryFallback: Circle
fallback: Box
} as const;
</script>
2 changes: 1 addition & 1 deletion src/lib/features/awesome-privacy/components/category-icon.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
const slug = $derived(awesomePrivacy.slugify(category));

const IconComponent = $derived(
(categoryIcons as Record<string, typeof Icons.categoryFallback>)[slug] ?? Icons.categoryFallback
(categoryIcons as Record<string, typeof Icons.fallback>)[slug] ?? Icons.fallback
);
</script>

Expand Down
34 changes: 23 additions & 11 deletions src/lib/features/awesome-privacy/components/service-logo.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import type { Service } from '../types';

import { Icons } from '$lib/components/icons/icons.svelte';
import { cn } from '$lib/utils/cn';

type ServiceLogoProps = HTMLAttributes<HTMLImageElement> & {
Expand All @@ -11,17 +12,28 @@

let { service, class: klass, ...props }: ServiceLogoProps = $props();

let error = $state(false);

const fallback = $derived(`https://icon.horse/icon/${service.url}`);
</script>

<img
referrerpolicy="no-referrer"
src={service.icon ?? fallback}
onerror={(e) => {
const target = e.target as HTMLImageElement;
if (target.src !== fallback) target.src = fallback;
}}
alt={service.name}
class={cn('shrink-0 object-contain', klass)}
{...props}
/>
{#if error}
<Icons.fallback class={cn('shrink-0', klass)} />
{:else}
<img
referrerpolicy="no-referrer"
src={service.icon ?? fallback}
onerror={(e) => {
const target = e.target as HTMLImageElement;

if (target.src !== fallback) {
target.src = fallback;
} else if (target.src === fallback) {
error = true;
}
}}
alt={service.name}
class={cn('shrink-0 object-contain', klass)}
{...props}
/>
{/if}
Loading