Skip to content

fix: add loading spinner for service images loaded externally #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dottmp merged 1 commit into from
Apr 10, 2026
Merged

fix: add loading spinner for service images loaded externally #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/lib/features/awesome-privacy/components/service-logo.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,15 @@
let { service, class: klass, ...props }: ServiceLogoProps = $props();

let error = $state(false);
let loading = $state(true);

const fallback = $derived(`https://icon.horse/icon/${service.url}`);
</script>

{#if loading}
<span class={cn('size-5 animate-pulse rounded-sm bg-base-300', klass)}></span>
{/if}

{#if error}
<Icons.fallback class={cn('shrink-0', klass)} />
{:else}
Expand All @@ -25,15 +30,20 @@
src={service.icon ?? fallback}
onerror={(e) => {
const target = e.target as HTMLImageElement;
loading = false;

if (target.src !== fallback) {
target.src = fallback;
} else if (target.src === fallback) {
error = true;
}
}}
onload={() => {
loading = false;
error = false;
}}
alt={service.name}
class={cn('shrink-0 object-contain', klass)}
class={cn('shrink-0 object-contain', loading && 'hidden', klass)}
{...props}
/>
{/if}
Loading