Fix: Create test_images directory if it doesn't exist#87
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Co-authored-by: doubleailes <23233470+doubleailes@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Create
Fix: Create test_images directory if it doesn't exist
Sep 26, 2025
test_images folder if it does not exist
doubleailes
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the
convert()function would fail when trying to save PNG files to thetest_imagesdirectory in fresh git clones or installations where this directory doesn't exist.Problem
The
convert()function incrates/crust-core/src/convert.rsgenerates PNG filenames using paths like./test_images/{timestamp}.pngvia theunique_timestamp()function. However, the function attempts to save files to this directory without ensuring it exists first, causing the save operation to fail with a directory not found error in fresh installations.Solution
Added automatic directory creation before attempting to save PNG files:
The fix uses
fs::create_dir_all()which:Changes
use std::fs;importtracing::errorandstd::process::exit(1)This ensures users can successfully run the conversion process immediately after cloning the repository without manual directory creation.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/doubleailes/ogawa-rs/commits/HEAD/home/REDACTED/.rustup/toolchains/1.89.0-x86_64-REDACTED-linux-gnu/bin/cargo check(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.