improve allocations in expression generator#444
Open
pquerna wants to merge 1 commit into
Open
Conversation
1ecc04b to
f2bce03
Compare
f2bce03 to
2488067
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed heavy allocation generation in a production workflow, which then generates lots of garbage collection pressure, coming from the dataset -> toSQL generation.
Adds benchmarks around the Expression SQL generator
Adds pooling of instances
Adds GrowBuffer/GrowArgs to upsize buffers when we know large writes are coming
Adds more native / non-reflection based writers
other minor optimizations