Skip to content

fix golint errors #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix golint errors #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 10 additions & 20 deletions core.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,6 @@ import (
"net/url"
)

const (
GET = "GET"
POST = "POST"
PUT = "PUT"
DELETE = "DELETE"
HEAD = "HEAD"
PATCH = "PATCH"
)

// GetSupported is the interface that provides the Get
// method a resource must support to receive HTTP GETs.
type GetSupported interface {
Expand Down Expand Up @@ -80,27 +71,27 @@ func (api *API) requestHandler(resource interface{}) http.HandlerFunc {
var handler func(url.Values, http.Header) (int, interface{}, http.Header)

switch request.Method {
case GET:
case "GET":
if resource, ok := resource.(GetSupported); ok {
handler = resource.Get
}
case POST:
case "POST":
if resource, ok := resource.(PostSupported); ok {
handler = resource.Post
}
case PUT:
case "PUT":
if resource, ok := resource.(PutSupported); ok {
handler = resource.Put
}
case DELETE:
case "DELETE":
if resource, ok := resource.(DeleteSupported); ok {
handler = resource.Delete
}
case HEAD:
case "HEAD":
if resource, ok := resource.(HeadSupported); ok {
handler = resource.Head
}
case PATCH:
case "PATCH":
if resource, ok := resource.(PatchSupported); ok {
handler = resource.Patch
}
Expand Down Expand Up @@ -131,13 +122,12 @@ func (api *API) requestHandler(resource interface{}) http.HandlerFunc {
// Mux returns the http.ServeMux used by an API. If a ServeMux has
// does not yet exist, a new one will be created and returned.
func (api *API) Mux() *http.ServeMux {
if api.muxInitialized {
return api.mux
} else {
if !api.muxInitialized {
api.mux = http.NewServeMux()
api.muxInitialized = true
return api.mux
}

return api.mux
}

// AddResource adds a new resource to an API. The API will route
Expand All @@ -161,7 +151,7 @@ func (api *API) AddResourceWithWrapper(resource interface{}, wrapper func(handle
// Start causes the API to begin serving requests on the given port.
func (api *API) Start(port int) error {
if !api.muxInitialized {
return errors.New("You must add at least one resource to this API.")
return errors.New("you must add at least one resource to this API")
}
portString := fmt.Sprintf(":%d", port)
return http.ListenAndServe(portString, api.Mux())
Expand Down