Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/supported_inventory_types.md
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,10 @@ See the docs on [how to add a new Extractor](/docs/new_extractor.md).
| HTTP CSRF Token | `secrets/csrftoken` |

### Sensitive information
| Type | Extractor Plugin |
| ------------------------------------------- | ------------------------------------ |
| Type | Extractor Plugin |
| ------------------------------------------- | -------------------------------------- |
| International Bank Account Number | `sensitiveinformation/iban` |
| US Passport Number | `secrets/uspassport` |
| US Social Security Number | `sensitiveinformation/ssn` |

### Container inventory
Expand Down
2 changes: 2 additions & 0 deletions extractor/filesystem/list/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ import (
"github.com/google/osv-scalibr/veles/secrets/vapid"
"github.com/google/osv-scalibr/veles/sensitiveinformation/iban"
"github.com/google/osv-scalibr/veles/sensitiveinformation/ssn"
"github.com/google/osv-scalibr/veles/sensitiveinformation/uspassport"

cpb "github.com/google/osv-scalibr/binary/proto/config_go_proto"
)
Expand Down Expand Up @@ -459,6 +460,7 @@ var (
SensitiveInformationDetectors = initMapFromVelesPlugins([]velesPlugin{
{iban.NewDetector(), "sensitiveinformation/iban", 0},
{ssn.NewDetector(), "sensitiveinformation/ssn", 0},
{uspassport.NewDetector(), "secrets/uspassport", 0},
})

// Secrets contains both secret extractors and detectors.
Expand Down
50 changes: 50 additions & 0 deletions veles/sensitiveinformation/uspassport/detector.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
// Package uspassport implements US passport number detection logic.
package uspassport

import (
"bytes"
"regexp"

"github.com/google/osv-scalibr/veles"
"github.com/google/osv-scalibr/veles/sensitiveinformation"
"github.com/google/osv-scalibr/veles/sensitiveinformation/common/simpleregex"
)

const (
maxSecretLength = 9
contextWindowSize = 32
)

var passportRe = regexp.MustCompile(`\b[A-Z0-9][0-9]{8}\b`)
var passportKeywords = simpleregex.KeywordsRe([]string{
`\bpassport\b`,
`travel[\s-]*document`,
})

// NewDetector returns a Detector that finds US passport numbers.
func NewDetector() veles.Detector {
return simpleregex.Detector{
MaxLen: maxSecretLength,
Re: passportRe,
ContextWindowBefore: contextWindowSize,
ContextWindowAfter: contextWindowSize,
KeywordsRe: passportKeywords,
FromMatch: func(b []byte, contextMatch bool) (sensitiveinformation.SensitiveInformation, bool) {
likelihood := sensitiveinformation.LikelihoodUnlikely
if contextMatch {
likelihood = sensitiveinformation.LikelihoodLikely
}

finding := sensitiveinformation.SensitiveInformation{
InfoType: sensitiveinformation.InfoType{
Name: "PASSPORT_NUMBER",
Sensitivity: sensitiveinformation.SensitivityLevelHigh,
},
Likelihood: likelihood,
Raw: bytes.Clone(b),
}

return finding, true
},
}
}
294 changes: 294 additions & 0 deletions veles/sensitiveinformation/uspassport/detector_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,294 @@
// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package uspassport

import (
"bytes"
"strings"
"testing"

"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/google/osv-scalibr/veles"
"github.com/google/osv-scalibr/veles/sensitiveinformation"
"github.com/google/osv-scalibr/veles/velestest"
)

const testPassport = "A12345678"

func TestDetectorAcceptance(t *testing.T) {
velestest.AcceptDetector(
t,
NewDetector(),
testPassport,
passportFinding([]byte(testPassport)),
)
}

func TestDetect_truePositives(t *testing.T) {
e, err := veles.NewDetectionEngine([]veles.Detector{NewDetector()})
if err != nil {
t.Fatal(err)
}

cases := []struct {
name string
in []byte
want []veles.Secret
}{
{
name: "match_only",
in: []byte("A12345678"),
want: []veles.Secret{
passportFinding([]byte("A12345678")),
},
},
{
name: "numeric_first_character",
in: []byte("123456789"),
want: []veles.Secret{
passportFinding([]byte("123456789")),
},
},
{
name: "keyword_before",
in: []byte("us passport: A12345678"),
want: []veles.Secret{
passportFindingWithLikelihood([]byte("A12345678"), sensitiveinformation.LikelihoodLikely),
},
},
{
name: "keyword_after",
in: []byte("A12345678 passport number"),
want: []veles.Secret{
passportFindingWithLikelihood([]byte("A12345678"), sensitiveinformation.LikelihoodLikely),
},
},
{
name: "travel_document_keyword",
in: []byte("travel document number: A12345678"),
want: []veles.Secret{
passportFindingWithLikelihood([]byte("A12345678"), sensitiveinformation.LikelihoodLikely),
},
},
{
name: "multiple_matches",
in: []byte("A12345678 123456789 Z98765432"),
want: []veles.Secret{
passportFinding([]byte("A12345678")),
passportFinding([]byte("123456789")),
passportFinding([]byte("Z98765432")),
},
},
{
name: "multiple_matches_long_gap",
in: []byte("A12345678" + strings.Repeat(" ", 50000) + "Z98765432"),
want: []veles.Secret{
passportFinding([]byte("A12345678")),
passportFinding([]byte("Z98765432")),
},
},
}

for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
got, derr := e.Detect(t.Context(), bytes.NewBuffer(tc.in))
if derr != nil {
t.Fatal(derr)
}
if diff := cmp.Diff(tc.want, got, cmpopts.EquateEmpty()); diff != "" {
t.Errorf("Detect() diff (-want +got):\n%s", diff)
}
})
}
}

func TestDetect_keywordMatches(t *testing.T) {
e, err := veles.NewDetectionEngine([]veles.Detector{NewDetector()})
if err != nil {
t.Fatal(err)
}

cases := []struct {
name string
in []byte
}{
{
name: "us_passport",
in: []byte("us passport: A12345678"),
},
{
name: "usa_passport",
in: []byte("usa passport: A12345678"),
},
{
name: "united_states_passport",
in: []byte("united states passport: A12345678"),
},
{
name: "american_passport",
in: []byte("american passport: A12345678"),
},
{
name: "passport_number",
in: []byte("passport number: A12345678"),
},
{
name: "passport_no",
in: []byte("passport no: A12345678"),
},
{
name: "passport_num",
in: []byte("passport num: A12345678"),
},
{
name: "passport_hash",
in: []byte("passport #: A12345678"),
},
{
name: "us_passport_number",
in: []byte("us passport number: A12345678"),
},
{
name: "us_passport_no",
in: []byte("us passport no: A12345678"),
},
{
name: "us_passport_hash",
in: []byte("us passport #: A12345678"),
},
{
name: "us_travel_document",
in: []byte("us travel document: A12345678"),
},
{
name: "united_states_travel_document",
in: []byte("united states travel document: A12345678"),
},
{
name: "travel_document_number",
in: []byte("travel document number: A12345678"),
},
{
name: "passport_book_number",
in: []byte("passport book number: A12345678"),
},
{
name: "passport_card_number",
in: []byte("passport card number: A12345678"),
},
{
name: "case_insensitive",
in: []byte("US PASSPORT: A12345678"),
},
}

for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
got, derr := e.Detect(t.Context(), bytes.NewBuffer(tc.in))
if derr != nil {
t.Fatal(derr)
}
want := []veles.Secret{
passportFindingWithLikelihood([]byte("A12345678"), sensitiveinformation.LikelihoodLikely),
}
if diff := cmp.Diff(want, got, cmpopts.EquateEmpty()); diff != "" {
t.Errorf("Detect() diff (-want +got):\n%s", diff)
}
})
}
}

func TestDetect_trueNegatives(t *testing.T) {
e, err := veles.NewDetectionEngine([]veles.Detector{NewDetector()})
if err != nil {
t.Fatal(err)
}

cases := []struct {
name string
in []byte
}{
{
name: "no_match",
in: []byte("not a passport number"),
},
{
name: "too_short",
in: []byte("A1234567"),
},
{
name: "too_long",
in: []byte("A123456789"),
},
{
name: "lowercase_first_character",
in: []byte("a12345678"),
},
{
name: "second_character_alpha",
in: []byte("AB2345678"),
},
{
name: "contains_dash",
in: []byte("A1234-678"),
},
{
name: "contains_space",
in: []byte("A1234 678"),
},
{
name: "within_longer_string",
in: []byte("asdfA12345678asdf"),
},
{
name: "within_underscores",
in: []byte("asdf_A12345678_asdf"),
},
}

for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
got, derr := e.Detect(t.Context(), bytes.NewBuffer(tc.in))
if derr != nil {
t.Fatal(derr)
}
if diff := cmp.Diff([]veles.Secret(nil), got, cmpopts.EquateEmpty()); diff != "" {
t.Errorf("Detect() diff (-want +got):\n%s", diff)
}
})
}
}

func TestDetectorMaxSecretLen(t *testing.T) {
if got, want := NewDetector().MaxSecretLen(), uint32(len("A12345678")+(2*contextWindowSize)); got != want {
t.Errorf("MaxSecretLen() = %d, want %d", got, want)
}
}

func passportFinding(raw []byte) sensitiveinformation.SensitiveInformation {
return passportFindingWithLikelihood(raw, sensitiveinformation.LikelihoodUnlikely)
}

func passportFindingWithLikelihood(raw []byte, likelihood sensitiveinformation.Likelihood) sensitiveinformation.SensitiveInformation {
return sensitiveinformation.SensitiveInformation{
InfoType: sensitiveinformation.InfoType{
Name: "PASSPORT_NUMBER",
Sensitivity: sensitiveinformation.SensitivityLevelHigh,
},
Likelihood: likelihood,
Raw: raw,
}
}
Loading