Conversation
…y1OfReal to math_Vector This commit migrates local variables in CSLib.cxx from TColStd_Array1OfReal to math_Vector: - Ratio array (local variable in Normal function) - Sol0 array (local variable in Normal function) Both variables are strictly local and not returned outside their scope, making the migration safe. Member variables in CSLib_Class2d and CSLib_NormalPolyDef remain unchanged as per requirements. Updated includes: - Added: math_Vector.hxx - Removed: TColStd_Array1OfReal.hxx (no longer needed in this file)
…OfReal to math_Vector This commit migrates CSLib_NormalPolyDef to use math_Vector instead of TColStd_Array1OfReal. This migration was necessary because the class is instantiated in CSLib.cxx with a math_Vector parameter (after previous migration). Changes: - Constructor parameter: const TColStd_Array1OfReal& -> const math_Vector& - Member variable myTABli: TColStd_Array1OfReal -> math_Vector - Updated includes: replaced TColStd_Array1OfReal.hxx with math_Vector.hxx The member variable is private and never exposed outside the class, making the migration safe. The constructor is only called once in CSLib.cxx.
|
Warning Rate limit exceeded@dpasukhi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 20 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThe PR replaces Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… to math_Vector This commit migrates CSLib_Class2d to use math_Vector instead of TColStd_Array1OfReal for its internal coordinate storage. Changes: - Member variables MyPnts2dX, MyPnts2dY: NCollection_Handle<TColStd_Array1OfReal> -> NCollection_Handle<math_Vector> - Allocation in Init(): new TColStd_Array1OfReal -> new math_Vector - Updated includes: replaced TColStd_Array1OfReal.hxx with math_Vector.hxx The member variables are private and never exposed through the public interface. All public methods work with gp_Pnt2d and return Standard_Integer, making this migration completely safe and transparent to users of the class. With this commit, CSLib directory is now completely migrated - all TColStd_Array1OfReal usage has been replaced with math_Vector.
c4e23d0 to
9318485
Compare
This commit migrates local variables in CSLib.cxx from TColStd_Array1OfReal to math_Vector:
Both variables are strictly local and not returned outside their scope, making the migration safe. Member variables in CSLib_Class2d and CSLib_NormalPolyDef remain unchanged as per requirements.
Updated includes: