Skip to content

fix(@dpc-sdp/ripple-ui-core): vertical nav feedback#1362

Open
lambry wants to merge 1 commit intomainfrom
feature/vertical-nav-feedback
Open

fix(@dpc-sdp/ripple-ui-core): vertical nav feedback#1362
lambry wants to merge 1 commit intomainfrom
feature/vertical-nav-feedback

Conversation

@lambry
Copy link
Contributor

@lambry lambry commented Mar 13, 2026

Issue: https://digital-vic.atlassian.net/browse/SD-1412

What I did

  • Design feedback
    • Icon: update spacing, focus display, and restore icon rotation when expanded
  • Remove .only so all tests run
  • Remove getParentChain so active item is set in ripple framework
    • This would be nice, i.e. only having to set a single deeply nested item as active and it figures out which parents need to be active, unfortunately as is, this was breaking the current ripple sites behaviour so now we don't get any active children being displayed correctly
    • This just reverts the behaviour for now so it's closer to what it was previously to address the regression
    • There was a new test called "top level items are highlighted and closed when active", I couldn't find any detail about this new behavour, the doc seems to suggest we don't want this? https://digital-vic.atlassian.net/wiki/spaces/RPL/pages/3757703178/Vertical+Navigation+New+Nov25#Accordion-item-behaviour (Please correct me if I'm wrong)

Notes:

How to test

Current prod (displays the current menu as open/active):

Previous vertical nav update (does not display the current menu as open/active):

Updates with this PR (displays the current menu as open/active once more):

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

fix icon spacing, focus display, and rotation, remove .only so all tests run, remove getParentChain so active item is set in ripple framework
@lambry lambry self-assigned this Mar 13, 2026
@lambry lambry requested review from a team, dylankelly, jeffdowdle and waitingallday and removed request for jeffdowdle March 13, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants