docs(security): update Azure OAuth2 config to use /v2.0/ endpoint #2350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfirke
force-pushed
the
update_azure_oauth
branch
from
62ce397 to
e93b540
Compare
sfirke
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had used the existing Azure OAuth config from this repo for several years in my Superset instance. Now our Azure Entra is requiring multi-factor authentication and we could not find a way to force MFA with that config.
The solution was to move to the v2.0 endpoint, which has been available for at least six years. Many GitHub posts, gists, StackOverflow posts show people using this newer config for Airflow and Superset. E.g., this popular gist.
This has been tested on my Superset including that mapping of AD group to Superset roles works. Users still get assigned roles correctly if that is configured following the FAB docs.
I also updated the toy Azure config in the OAuth examples file, for good measure. Note: I misunderstood this file in an earlier version of the PR - I've edited this description and force-pushed updated code upon properly understanding and using that example.
ADDITIONAL INFORMATION