Skip to content

fix: upgrade swc_common to 14.0.4#74

Merged
dsherret merged 1 commit intodprint:mainfrom
Foorack:swc-common-1404
Sep 16, 2025
Merged

fix: upgrade swc_common to 14.0.4#74
dsherret merged 1 commit intodprint:mainfrom
Foorack:swc-common-1404

Conversation

@Foorack
Copy link
Contributor

@Foorack Foorack commented Sep 16, 2025

SWC relied on an internal API, which broke in serde 220. swc-project/swc#11094

This PR bumps swc_common from 14.0.3 to 14.0.4.

Copilot AI review requested due to automatic review settings September 16, 2025 18:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the swc_common dependency from version 14.0.3 to 14.0.4 to fix a compatibility issue with serde 220, where SWC's reliance on an internal API was broken.

  • Updates swc_common dependency version to resolve serde compatibility issues

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dsherret dsherret changed the title feat: upgrade swc_common to 14.0.4 fix: upgrade swc_common to 14.0.4 Sep 16, 2025
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I probably won't bother with a release though because the published version will automatically pull in 14.0.4. Do you need this for using Deno crates? If so, it would be good to bump this up one because it's pinned there: https://github.com/denoland/deno_ast/blob/0cd62638cfe7e2333176119212524f7533f049ba/Cargo.toml#L53

@dsherret dsherret merged commit 1fcde8b into dprint:main Sep 16, 2025
2 checks passed
@Foorack Foorack deleted the swc-common-1404 branch September 16, 2025 18:18
@Foorack
Copy link
Contributor Author

Foorack commented Sep 16, 2025

@dsherret Wow, that was fast! I was like "Huh, where did the PR go?", but it had moved to the "Closed" tab. 😃

And thanks for the tip! I am now working on making a pull request to deno_ast next. 👍

@Foorack
Copy link
Contributor Author

Foorack commented Sep 16, 2025

Done! denoland/deno_ast#319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants