Skip to content

feat(postcodes/GP): add Guadeloupe major-commune postcodes (#1039) #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dr5hn merged 2 commits into from
Apr 27, 2026
Merged

feat(postcodes/GP): add Guadeloupe major-commune postcodes (#1039) #1424

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e753278
feat(postcodes/GP): add Guadeloupe major-commune postcodes (#1039)
dr5hn Apr 27, 2026
e1a3f8f
fix(postcodes/GP): sort records by code; align Baie-Mahault state wit…
dr5hn Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions contributions/postcodes/GP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
[
{
"code": "97100",
"country_id": 88,
"country_code": "GP",
"state_id": 5384,
"state_code": "01",
"locality_name": "Basse-Terre",
"type": "full",
"source": "manual"
},
{
"code": "97120",
"country_id": 88,
"country_code": "GP",
"state_id": 5384,
"state_code": "01",
"locality_name": "Saint-Claude",
"type": "full",
"source": "manual"
},
{
"code": "97110",
"country_id": 88,
"country_code": "GP",
"state_id": 5385,
"state_code": "02",
"locality_name": "Pointe-a-Pitre",

Copilot AI Apr 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Postcode entries appear to be expected in ascending code order (e.g., contributions/postcodes/GF.json, LI.json). Here 97120 is listed before 97110, which breaks ordering and makes diffs/maintenance harder. Please reorder the objects by code (97100, 97110, 97120, 97122).

Suggested change
"code": "97120",
"country_id": 88,
"country_code": "GP",
"state_id": 5384,
"state_code": "01",
"locality_name": "Saint-Claude",
"type": "full",
"source": "manual"
},
{
"code": "97110",
"country_id": 88,
"country_code": "GP",
"state_id": 5385,
"state_code": "02",
"locality_name": "Pointe-a-Pitre",
"code": "97110",
"country_id": 88,
"country_code": "GP",
"state_id": 5385,
"state_code": "02",
"locality_name": "Pointe-a-Pitre",
"type": "full",
"source": "manual"
},
{
"code": "97120",
"country_id": 88,
"country_code": "GP",
"state_id": 5384,
"state_code": "01",
"locality_name": "Saint-Claude",

Copilot uses AI. Check for mistakes.
"type": "full",
"source": "manual"
},
{
"code": "97122",
"country_id": 88,
"country_code": "GP",
"state_id": 5385,
"state_code": "02",

Copilot AI Apr 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baie-Mahault is assigned to state_id 5385 / state_code "02" here, but the existing city record in contributions/cities/GP.json assigns Baie-Mahault to state_id 5384 / state_code "01". To keep cross-file consistency for GP, please either align this postcode record’s state fields with the existing city/state mapping, or update the related city/state mapping in the same PR so all references agree.

Suggested change
"state_id": 5385,
"state_code": "02",
"state_id": 5384,
"state_code": "01",

Copilot uses AI. Check for mistakes.
"locality_name": "Baie-Mahault",
"type": "full",
"source": "manual"
}
]
Loading