Skip to content

Duplicate state 'OSH' (state_id: 1003) removed from the geojson, jso…#1540

Open
fullmetalldev wants to merge 1 commit into
dr5hn:masterfrom
fullmetalldev:master
Open

Duplicate state 'OSH' (state_id: 1003) removed from the geojson, jso…#1540
fullmetalldev wants to merge 1 commit into
dr5hn:masterfrom
fullmetalldev:master

Conversation

@fullmetalldev
Copy link
Copy Markdown

…n, csv files for the country - Kyrgyzstan.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. fixed Issue has been fixed labels May 7, 2026
Copy link
Copy Markdown
Owner

dr5hn commented May 11, 2026

Weekly data-quality review (2026-05-11)

Verdict: needs-fix

Checks

  • Schema: ❌ This PR edits auto-generated files (json/states.json, json/countries+states.json, json/countries+states+cities.json). Per repo conventions, only contributions/ files are the source of truth; json/ is regenerated automatically and must not be edited directly.
  • FK integrity: ✅ / N/A — No contributions/ files were changed; the canonical data is unaffected by this PR.
  • Coordinates: ✅ No coordinate changes.
  • Wikidata: N/A — Wikidata endpoints returned 403 (persistent network failure during review).
  • Naming convention: ✅ No name changes.

Specific concerns

  1. Wrong files edited. All three changed files live under json/, which is an auto-generated export directory. Changes here are silently overwritten on every export run. The correct target is contributions/states/states.json.

  2. Potentially incorrect removal. The two "Osh" entries in contributions/states/states.json are distinct administrative entities:

    • id=1003, iso2=GO, iso3166_2=KG-GOOsh City (a first-level administrative unit, analogous to KG-GB = Bishkek)
    • id=1005, iso2=O, iso3166_2=KG-OOsh Oblast/Region

    Both KG-GO and KG-O are valid, distinct subdivisions under ISO 3166-2:KG. Removing KG-GO (Osh City) may be incorrect. Please confirm against the current ISO 3166-2:KG standard before proceeding. If the removal is confirmed correct, the change must be made in contributions/states/states.json and re-exported through the normal pipeline.

🤖 Automated weekly review — Claude (sonnet-4-6).


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixed Issue has been fixed size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants