fix(JP): update Japan Post KEN_ALL download URL (closes #1543)#1544
Open
Tanoshima wants to merge 1 commit into
Open
fix(JP): update Japan Post KEN_ALL download URL (closes #1543)#1544Tanoshima wants to merge 1 commit into
Tanoshima wants to merge 1 commit into
Conversation
Japan Post moved the ken_all.zip download endpoint; the previous /zipcode/dl/kogaki/ path returns 404. Replace it with the new /service/search/zipcode/download/kogaki/ path in both the docstring header and the usage example so re-running the importer succeeds. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dosubot
Bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ken_all.zipdownload endpoint. The old URLhttps://www.post.japanpost.jp/zipcode/dl/kogaki/zip/ken_all.zipnow returns 404.https://www.post.japanpost.jp/service/search/zipcode/download/kogaki/zip/ken_all.zipin both locations insidebin/scripts/sync/import_japan_post_postcodes.py(header docstring + usage example).Closes #1543.
Source
HTTP/2 200)HTTP/1.1 404)Test plan
curl -sIon the new URL returns 200 (after following redirects)curl -sIon the old URL returns 404python3 -c "import urllib.request; urllib.request.urlretrieve('https://www.post.japanpost.jp/service/search/zipcode/download/kogaki/zip/ken_all.zip', '/tmp/ken_all.zip')"and confirm the zip downloadspython3 bin/scripts/sync/import_japan_post_postcodes.py --input /tmp/KEN_ALL.CSVend-to-end🤖 Generated with Claude Code