fix handling of late offer scenarios#20
Open
rhondahollis wants to merge 2 commits intodrachtio:masterfrom
Open
fix handling of late offer scenarios#20rhondahollis wants to merge 2 commits intodrachtio:masterfrom
rhondahollis wants to merge 2 commits intodrachtio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@davehorton these changes provide a fix to perform the sdp transformation for webrtc on a 3pcc call, and cleans up the reInvite handling, fixing an issue where the full list of codecs were not returned in response to a late-offer reInvite.
I was unable to get
npm installto use the generic registry, so I didn't push up package-lock.json. If you are able to add that to these changes, I'd appreciate it. Thanks!