Skip to content

Move to async plus add modify & notify#5

Draft
danjenkins wants to merge 4 commits intodrachtio:masterfrom
nimbleape:move-to-async-plus-modify
Draft

Move to async plus add modify & notify#5
danjenkins wants to merge 4 commits intodrachtio:masterfrom
nimbleape:move-to-async-plus-modify

Conversation

@danjenkins
Copy link
Copy Markdown

  • Added an example Dockerfile using Multistage build
  • Added in Modify & Notify methods so that you can now handle transfers/renegotiations
  • Moved to using async/await purely because it encourages users to use them instead of chaining promise after promise
  • Moved everything to use the same formatting - no spaces inbetween end of statement and the ;
  • Enabled Drachtio Outbound mode - encourages use of it - so much easier to scale with it!

Not tested yet - hence draft PR. If you don't object to the async/await changes then I'll go ahead of test against a webrtc softphone

@danjenkins
Copy link
Copy Markdown
Author

Thanks @davehorton - seems like I still have a bug around my modify logic though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants