ci: unify timeout to 10 min by default#2337
Draft
bdrung wants to merge 1 commit into
Draft
Conversation
Contributor
|
With GitHub Action workflow what is the primary benefit for the project of lowering the timeout ? Just the test fails faster? For this little benefit, does it make sense to introduce the complexity of variable timeouts within a test matrix ? |
Member
Author
|
The benefit is a faster failing test in case the test hangs and freeing running quicker. |
Collaborator
|
needs rebase |
Most tests take only a few seconds or minutes on AMD. The tests on ARM are two to four times slower than their AMD counterparts (due to not using KVM). All tests finish in under five minutes except test 60-NFS on AMD (which can take six to seven minutes) and following tests on ARM: | Test | Duration | Timeout | | ----------------- | --------- | ------- | | 11-USR-MOUNT | 5-10 min | 20 min | | 20-STORAGE | 9-22 min | 40 min | | 21-OVERLAYFS | 5-11 min | 20 min | | 26-ENC-RAID-LVM | 9-21 min | 40 min | | 30-DMSQUASH | 5-10 min | 20 min | | 41-FULL-SYSTEMD | 5-9 min | 20 min | | 45-SYSTEMD-IMPORT | 7 min | 20 min | | 60-NFS | 19-49 min | 60 min | | 71-ISCSI | 9 min | 20 min | | 72-ISCSI-MULTI | 9-20 min | 40 min | So use a 10 min timeout on all AMD tests and most ARM tests, but increase the timeout for ARM for those test mentioned above. So use 20 min timeout for several ARM tests, 40 min timeout for 20-STORAGE, 26-ENC-RAID-LVM, 72-ISCSI-MULTI on ARM, and 60 min timeout for 60-NFS on ARM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most tests take only a few seconds or minutes on AMD. The tests on ARM are two to four times slower than their AMD counterparts (due to not using KVM).
All tests finish in under five minutes except test 60-NFS on AMD (which can take six to seven minutes) and following tests on ARM:
So use a 10 min timeout on all AMD tests and most ARM tests, but increase the timeout for ARM for those test mentioned above. So use 20 min timeout for several ARM tests, 40 min timeout for 20-STORAGE, 26-ENC-RAID-LVM, 72-ISCSI-MULTI on ARM, and 60 min timeout for 60-NFS on ARM.
Checklist