Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate persistent task id by wyhash #946

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jan 17, 2025

This pull request includes several updates and improvements across multiple files in the dragonfly-client project. The most important changes include updating dependencies, switching the hashing algorithm, adding logging for better traceability, and modifying request handling to improve error reporting and timeout management.

Dependency updates:

Hashing algorithm switch:

Logging improvements:

Request handling improvements:

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added the enhancement New feature or request label Jan 17, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Jan 17, 2025
@gaius-qi gaius-qi self-assigned this Jan 17, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner January 17, 2025 04:09
@gaius-qi gaius-qi force-pushed the feature/persistent-id branch from a5a335f to 577c55f Compare January 17, 2025 04:19
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 34.29%. Comparing base (80dfd4d) to head (351cbe6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...onfly-client/src/resource/persistent_cache_task.rs 0.00% 6 Missing ⚠️
dragonfly-client/src/bin/dfcache/import.rs 0.00% 4 Missing ⚠️
dragonfly-client/src/grpc/dfdaemon_download.rs 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
- Coverage   34.32%   34.29%   -0.03%     
==========================================
  Files          60       60              
  Lines        9320     9327       +7     
==========================================
  Hits         3199     3199              
- Misses       6121     6128       +7     
Files with missing lines Coverage Δ
dragonfly-client-util/src/id_generator/mod.rs 100.00% <100.00%> (ø)
dragonfly-client/src/grpc/dfdaemon_download.rs 0.00% <0.00%> (ø)
dragonfly-client/src/bin/dfcache/import.rs 0.00% <0.00%> (ø)
...onfly-client/src/resource/persistent_cache_task.rs 0.00% <0.00%> (ø)

@gaius-qi gaius-qi force-pushed the feature/persistent-id branch 4 times, most recently from 76d980e to 668568e Compare January 17, 2025 10:39
@gaius-qi gaius-qi changed the title feat: generate persistent task id by crc32 feat: generate persistent task id by wyhash Jan 17, 2025
hhhhsdxxxx
hhhhsdxxxx previously approved these changes Jan 17, 2025
@gaius-qi gaius-qi force-pushed the feature/persistent-id branch from 668568e to 351cbe6 Compare January 17, 2025 12:01
@gaius-qi gaius-qi merged commit bb86c3b into main Jan 17, 2025
5 of 6 checks passed
@gaius-qi gaius-qi deleted the feature/persistent-id branch January 17, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants