Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add args for dfcache #947

Merged
merged 1 commit into from
Jan 20, 2025
Merged

feat: add args for dfcache #947

merged 1 commit into from
Jan 20, 2025

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added the enhancement New feature or request label Jan 20, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Jan 20, 2025
@gaius-qi gaius-qi self-assigned this Jan 20, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner January 20, 2025 03:16
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 106 lines in your changes missing coverage. Please review.

Project coverage is 34.05%. Comparing base (bb86c3b) to head (e985548).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/bin/dfcache/export.rs 0.00% 25 Missing ⚠️
dragonfly-client/src/bin/dfcache/import.rs 0.00% 25 Missing ⚠️
dragonfly-client/src/bin/dfcache/remove.rs 0.00% 25 Missing ⚠️
dragonfly-client/src/bin/dfcache/stat.rs 0.00% 25 Missing ⚠️
dragonfly-client/src/bin/dfcache/main.rs 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #947      +/-   ##
==========================================
- Coverage   34.29%   34.05%   -0.25%     
==========================================
  Files          60       60              
  Lines        9327     9395      +68     
==========================================
  Hits         3199     3199              
- Misses       6128     6196      +68     
Files with missing lines Coverage Δ
dragonfly-client/src/bin/dfcache/main.rs 0.00% <0.00%> (ø)
dragonfly-client/src/bin/dfcache/export.rs 0.00% <0.00%> (ø)
dragonfly-client/src/bin/dfcache/import.rs 0.00% <0.00%> (ø)
dragonfly-client/src/bin/dfcache/remove.rs 0.00% <0.00%> (ø)
dragonfly-client/src/bin/dfcache/stat.rs 0.00% <0.00%> (ø)

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 2d4c54d into main Jan 20, 2025
6 checks passed
@gaius-qi gaius-qi deleted the feature/dfcache branch January 20, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants