Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set permissions for Unix Domain Socket in dfdaemon_download #981

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes changes to the dragonfly-client to enhance the handling of Unix domain sockets and permissions.

Enhancements to Unix domain sockets and permissions:

Related Issue

dragonflyoss/dragonfly#3811

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 14, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Feb 14, 2025
@gaius-qi gaius-qi self-assigned this Feb 14, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner February 14, 2025 06:04
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.07%. Comparing base (04c71e6) to head (fa7bb66).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #981   +/-   ##
=======================================
  Coverage   33.07%   33.07%           
=======================================
  Files          59       59           
  Lines        9741     9741           
=======================================
  Hits         3222     3222           
  Misses       6519     6519           
Files with missing lines Coverage Δ
dragonfly-client/src/grpc/dfdaemon_download.rs 0.00% <ø> (ø)

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 991ecd3 into main Feb 14, 2025
6 checks passed
@chlins chlins deleted the feature/uds branch February 14, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants