Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add trivy action for vulnerability scanner #983

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Feb 17, 2025

Description

This pull request includes the addition of a Trivy vulnerability scanner and the upload of scan results to the GitHub Security tab in the .github/workflows/docker.yml file. These changes enhance the security checks during the CI/CD pipeline.

Security enhancements:

  • Added a step to run the Trivy vulnerability scanner in tarball mode, scanning for critical and high severity issues, and outputting the results in SARIF format. [1] [2]
  • Added a step to upload the Trivy scan results to the GitHub Security tab using the github/codeql-action/upload-sarif action. [1] [2]

Related Issue

dragonflyoss/dragonfly#3811

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 17, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Feb 17, 2025
@gaius-qi gaius-qi self-assigned this Feb 17, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner February 17, 2025 03:05
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.12%. Comparing base (d0fa28a) to head (c347fa3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #983   +/-   ##
=======================================
  Coverage   33.12%   33.12%           
=======================================
  Files          59       59           
  Lines        9750     9750           
=======================================
  Hits         3230     3230           
  Misses       6520     6520           

Copy link
Contributor

@CormickKneey CormickKneey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 42c2906 into main Feb 17, 2025
5 of 6 checks passed
@gaius-qi gaius-qi deleted the feature/trivy branch February 17, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants