Skip to content
This repository was archived by the owner on Dec 20, 2024. It is now read-only.

Conversation

@itttl
Copy link

@itttl itttl commented Dec 16, 2020

Ⅰ. Describe what this PR did

k8s supernode and dfclient yaml demo config file

Ⅱ. Does this pull request fix one issue?

no

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

yes,this is a reference doc.

Ⅳ. Describe how to verify it

create pod

Ⅴ. Special notes for reviews

need modify your harbor ip,supernode ip,images

@@ -0,0 +1,42 @@
kind: DaemonSet
apiVersion: apps/v1beta2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The apps/v1beta2/DaemonSet apiVersion is deprecated. Please update.

@@ -1,0 +1,5 @@
## supernode.yaml
supernode的yaml文件,nodeport端口映射
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update english docs first.

labels:
app: node-dfclient
name: node-dfclient
namespace: kube-system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a new namespace "dragonfly-system" is better

spec:
containers:
- name: node-dfclient
image: 10.1.1.5/kube-system/dfclient:1.0.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to docker hub image for public.

command:
- /opt/dragonfly/df-client/dfdaemon
- --registry
- http://10.1.1.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment here for custom image registry

labels:
app: supernode
spec:
affinity:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove affinity

- ai-node-25
containers:
- name: supernode
image: 10.1.1.5/kube-system/supernode:1.0.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change like node-dfclient

name: download-port
- containerPort: 8002
hostPort: 8002
name: harbor-port
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

harbor port ? it should be nginx port

path: /data/dragonfly/supernode
hostNetwork: true
hostPID: true
tolerations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment should not tolerate all taints.

labels:
app: supernode
name: supernode-svc
namespace: kube-system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace "dragonfly-system"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants