This repository was archived by the owner on Dec 20, 2024. It is now read-only.
Fix goroutine leak bug in DoDownloadTimeout#1565
Open
timmyyuan wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ting Yuan <yuanting@ict.ac.cn>
9d765ef to
aa4e2c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
This PR fix a goroutine leak bug in DoDownloadTimeout
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)?
This fix is already covered by
TestDoDownloadTimeoutⅣ. Describe how to verify it
In the original code,
DoDownloadTimeouthas a potential goroutine leak in rare goroutine intervening. It can be verified by using https://github.com/uber-go/goleak if we instrument the entry offunc Test(t *testing.T)indfget/core/downloader/downloader_test.goand then runTestDoDownloadTimeoutenough times:This command results in :
Ⅴ. Special notes for reviews