Conversation
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3997 +/- ##
==========================================
- Coverage 34.31% 34.30% -0.02%
==========================================
Files 342 342
Lines 40139 40150 +11
==========================================
- Hits 13775 13774 -1
- Misses 25454 25466 +12
Partials 910 910
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
chlins
reviewed
Apr 25, 2025
…/files Signed-off-by: Gaius <gaius.qi@gmail.com>
CormickKneey
approved these changes
Apr 25, 2025
yxxhero
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces enhancements to the preheat job creation logic, making it more flexible and robust by supporting multiple file URLs and improving parameter validation. It also includes minor updates to comments for better clarity.
Enhancements to preheat job creation:
URLparameter is required for image preheat jobs. IfURLis missing, an error is returned. (manager/job/preheat.go, manager/job/preheat.goR119-R140)URLand multipleURLs. If both are provided,URLstakes precedence, and theURLis appended to the list ofURLs. Validation ensures at least one ofURLorURLsis provided. (manager/job/preheat.go, [1] [2]Updates to type definitions:
Typefield inCreatePreheatJobRequestto reflect its purpose more accurately. (manager/types/job.go, manager/types/job.goL94-R94)URLfield comment inPreheatArgsto indicate it can represent either an image or file URL. Added a newURLsfield to support multiple file URLs, with a note on its priority relative toURL. (manager/types/job.go, manager/types/job.goL111-R117)Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist