Skip to content

fix(.github/workflows): detected GitHub workflow tokens with excessive permissions in auto-assign.yml#4021

Merged
Liam-Zhao merged 1 commit intomainfrom
fix/permission
Apr 29, 2025
Merged

fix(.github/workflows): detected GitHub workflow tokens with excessive permissions in auto-assign.yml#4021
Liam-Zhao merged 1 commit intomainfrom
fix/permission

Conversation

@gaius-qi
Copy link
Copy Markdown
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

…e permissions in auto-assign.yml

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Apr 29, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Apr 29, 2025
@gaius-qi gaius-qi self-assigned this Apr 29, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner April 29, 2025 06:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the security concern by restricting GitHub workflow token permissions in the auto-assign workflow.

  • Added an explicit permissions block limiting the token to "pull-requests: write".
  • Updates the workflow configuration to minimize excess permissions.

Copy link
Copy Markdown

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liam-Zhao Liam-Zhao enabled auto-merge (squash) April 29, 2025 06:07
Copy link
Copy Markdown
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.24%. Comparing base (4d74f17) to head (bf32031).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4021      +/-   ##
==========================================
- Coverage   34.27%   34.24%   -0.03%     
==========================================
  Files         343      343              
  Lines       40197    40199       +2     
==========================================
- Hits        13777    13768       -9     
- Misses      25512    25520       +8     
- Partials      908      911       +3     
Flag Coverage Δ
unittests 34.24% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Liam-Zhao Liam-Zhao merged commit f45351f into main Apr 29, 2025
30 checks passed
@Liam-Zhao Liam-Zhao deleted the fix/permission branch April 29, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants