Skip to content

feat: bump client to v0.2.26 and add CRC32FromStrings func#4024

Merged
Liam-Zhao merged 1 commit intomainfrom
feature/client
Apr 29, 2025
Merged

feat: bump client to v0.2.26 and add CRC32FromStrings func#4024
Liam-Zhao merged 1 commit intomainfrom
feature/client

Conversation

@gaius-qi
Copy link
Copy Markdown
Member

Description

This pull request introduces changes to enhance functionality, update dependencies, and improve test coverage. The most significant updates include the addition of a new CRC32FromStrings function for generating checksums, updates to compatibility tests, and modifications to e2e tests for persistent cache task ID generation.

Functionality Enhancements:

  • Added a new CRC32FromStrings function in pkg/digest/digest.go to compute CRC32 checksums from multiple strings. This function is used for generating persistent cache task IDs.
  • Introduced a PersistentCacheTaskIDByContent function in pkg/idgen/task_id.go that utilizes CRC32FromStrings to generate task IDs for persistent caching.

Dependency Updates:

  • Updated the image tag for client and seed-client in .github/workflows/compatibility-e2e-v2.yml from v0.2.18 to v0.2.26.
  • Updated the client-rs submodule to a new commit (a15d556f959ff75c302608c6297f654fcb546f30).

Test Coverage Improvements:

  • Added a unit test for the CRC32FromStrings function in pkg/digest/digest_test.go.
  • Added a unit test for the PersistentCacheTaskIDByContent function in pkg/idgen/task_id_test.go.
  • Updated e2e tests in test/e2e/v2/dfcache_test.go to use PersistentCacheTaskIDByContent for task ID generation, replacing direct SHA256 usage. This change ensures consistency in persistent cache task ID generation. [1] [2] [3] [4] [5]

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Apr 29, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Apr 29, 2025
@gaius-qi gaius-qi self-assigned this Apr 29, 2025
@gaius-qi gaius-qi requested review from a team as code owners April 29, 2025 09:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 34.45%. Comparing base (f45351f) to head (26d57c5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/digest/digest.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4024      +/-   ##
==========================================
+ Coverage   34.27%   34.45%   +0.17%     
==========================================
  Files         343      343              
  Lines       40199    40211      +12     
==========================================
+ Hits        13778    13854      +76     
+ Misses      25513    25444      -69     
- Partials      908      913       +5     
Flag Coverage Δ
unittests 34.45% <50.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/idgen/task_id.go 82.35% <100.00%> (+0.72%) ⬆️
pkg/digest/digest.go 68.18% <40.00%> (-2.82%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link
Copy Markdown

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liam-Zhao Liam-Zhao enabled auto-merge (squash) April 29, 2025 17:26
@Liam-Zhao Liam-Zhao merged commit 47e6c33 into main Apr 29, 2025
28 checks passed
@Liam-Zhao Liam-Zhao deleted the feature/client branch April 29, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants