feat: bump client to v0.2.26 and add CRC32FromStrings func#4024
Merged
feat: bump client to v0.2.26 and add CRC32FromStrings func#4024
Conversation
495b60c to
7c2fdbe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4024 +/- ##
==========================================
+ Coverage 34.27% 34.45% +0.17%
==========================================
Files 343 343
Lines 40199 40211 +12
==========================================
+ Hits 13778 13854 +76
+ Misses 25513 25444 -69
- Partials 908 913 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Gaius <gaius.qi@gmail.com>
7c2fdbe to
26d57c5
Compare
yxxhero
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces changes to enhance functionality, update dependencies, and improve test coverage. The most significant updates include the addition of a new
CRC32FromStringsfunction for generating checksums, updates to compatibility tests, and modifications to e2e tests for persistent cache task ID generation.Functionality Enhancements:
CRC32FromStringsfunction inpkg/digest/digest.goto compute CRC32 checksums from multiple strings. This function is used for generating persistent cache task IDs.PersistentCacheTaskIDByContentfunction inpkg/idgen/task_id.gothat utilizesCRC32FromStringsto generate task IDs for persistent caching.Dependency Updates:
clientandseed-clientin.github/workflows/compatibility-e2e-v2.ymlfromv0.2.18tov0.2.26.client-rssubmodule to a new commit (a15d556f959ff75c302608c6297f654fcb546f30).Test Coverage Improvements:
CRC32FromStringsfunction inpkg/digest/digest_test.go.PersistentCacheTaskIDByContentfunction inpkg/idgen/task_id_test.go.test/e2e/v2/dfcache_test.goto usePersistentCacheTaskIDByContentfor task ID generation, replacing direct SHA256 usage. This change ensures consistency in persistent cache task ID generation. [1] [2] [3] [4] [5]Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist