Skip to content

comments(manager/config): add GRPCConfig struct for gRPC server confi…#4044

Merged
Liam-Zhao merged 1 commit intomainfrom
feat(manager/config)--add-GRPCConfig-struct-for-gRPC-server-configuration
May 7, 2025
Merged

comments(manager/config): add GRPCConfig struct for gRPC server confi…#4044
Liam-Zhao merged 1 commit intomainfrom
feat(manager/config)--add-GRPCConfig-struct-for-gRPC-server-configuration

Conversation

@yxxhero
Copy link
Copy Markdown
Member

@yxxhero yxxhero commented May 7, 2025

…guration

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

…guration

Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero yxxhero requested a review from a team as a code owner May 7, 2025 13:59
@yxxhero yxxhero requested review from BraveY, BruceAko and liubin May 7, 2025 13:59
@yxxhero yxxhero added the documentation Improvements or additions to documentation label May 7, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.40%. Comparing base (fb5e1d7) to head (0f5318b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4044   +/-   ##
=======================================
  Coverage   34.40%   34.40%           
=======================================
  Files         343      343           
  Lines       40211    40211           
=======================================
  Hits        13835    13835           
  Misses      25461    25461           
  Partials      915      915           
Flag Coverage Δ
unittests 34.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/config/config.go 96.18% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liam-Zhao Liam-Zhao enabled auto-merge (squash) May 7, 2025 14:39
@Liam-Zhao Liam-Zhao merged commit ae76b12 into main May 7, 2025
30 checks passed
@Liam-Zhao Liam-Zhao deleted the feat(manager/config)--add-GRPCConfig-struct-for-gRPC-server-configuration branch May 7, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants