Skip to content

Correct error logging format in InitMonitor function#4046

Merged
Liam-Zhao merged 1 commit intodragonflyoss:mainfrom
BruceAko:main
May 8, 2025
Merged

Correct error logging format in InitMonitor function#4046
Liam-Zhao merged 1 commit intodragonflyoss:mainfrom
BruceAko:main

Conversation

@BruceAko
Copy link
Copy Markdown
Member

@BruceAko BruceAko commented May 8, 2025

Description

Correct error logging format in InitMonitor function.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@BruceAko BruceAko requested a review from a team as a code owner May 8, 2025 02:15
@BruceAko BruceAko added dependencies Pull requests that update a dependency file bug labels May 8, 2025
Signed-off-by: BruceAko <chongzhi@hust.edu.cn>
@BruceAko BruceAko added go Pull requests that update Go code and removed dependencies Pull requests that update a dependency file labels May 8, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.43%. Comparing base (ae76b12) to head (474223f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/dependency/dependency.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4046      +/-   ##
==========================================
+ Coverage   34.40%   34.43%   +0.02%     
==========================================
  Files         343      343              
  Lines       40211    40211              
==========================================
+ Hits        13835    13845      +10     
+ Misses      25459    25453       -6     
+ Partials      917      913       -4     
Flag Coverage Δ
unittests 34.43% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/dependency/dependency.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liam-Zhao Liam-Zhao enabled auto-merge (squash) May 8, 2025 02:25
Copy link
Copy Markdown
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liam-Zhao Liam-Zhao merged commit 530ba54 into dragonflyoss:main May 8, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants