fix: add the authorization for get configs API#4067
Merged
Conversation
Signed-off-by: chlins <chlins.zhang@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4067 +/- ##
=======================================
Coverage 34.39% 34.39%
=======================================
Files 346 346
Lines 40451 40451
=======================================
Hits 13914 13914
Misses 25621 25621
Partials 916 916
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the routing logic for the
/configsAPI endpoints inmanager/router/router.goto simplify middleware handling. The most important change consolidates thejwt.MiddlewareFunc()andrbacmiddleware into the group definition, reducing redundancy in individual route declarations.Routing refactor:
jwt.MiddlewareFunc()andrbacmiddleware into the group definition for/configsAPI endpoints, simplifying the route definitions. Individual routes no longer explicitly include these middleware calls. ([manager/router/router.goL207-R211](https://github.com/dragonflyoss/dragonfly/pull/4067/files#diff-accc11d77962a73f2df2837787ed0d45a6a0d5ca6a020c3eec7726f447db2d9cL207-R211))Description
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist