Conversation
… for weak network conditions Signed-off-by: Gaius <gaius.qi@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4072 +/- ##
=======================================
Coverage 34.37% 34.38%
=======================================
Files 346 346
Lines 40486 40489 +3
=======================================
+ Hits 13917 13922 +5
+ Misses 25653 25651 -2
Partials 916 916
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces updates to dependency versions, refines Redis configuration defaults, and modifies task group handling to improve performance and maintainability. The most notable changes include upgrading the
dragonflyoss/machinerydependency, updating Redis-related constants, and adjusting task group timeout values.Dependency Updates:
dragonflyoss/machineryto versionv1.10.13ingo.modfor compatibility and bug fixes.Redis Configuration Enhancements:
internal/job/constants.go:DefaultRedisMaxIdleto0and introducedDefaultRedisMaxActivewith a value of300.DefaultRedisIdleTimeoutto30seconds.DefaultRedisNormalTasksPollPeriod = 2000) and delayed tasks (DefaultRedisDelayedTasksPollPeriod = 500).internal/job/job.go.Task Group Timeout Adjustments:
SendGroupWithContextcalls from0to50across multiple functions to improve task group handling:createGroupJobinmanager/job/preheat.go.CreateGetTaskinmanager/job/task.go.CreateDeleteTaskinmanager/job/task.go.Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist