feat(manager): add ratelimiter for job oapi#4088
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4088 +/- ##
=========================================
+ Coverage 0 33.26% +33.26%
=========================================
Files 0 346 +346
Lines 0 40493 +40493
=========================================
+ Hits 0 13471 +13471
- Misses 0 26131 +26131
- Partials 0 891 +891
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Gaius <gaius.qi@gmail.com>
c259175 to
79ccf74
Compare
CormickKneey
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes the removal of a large test file and the addition of a rate limiter middleware to a job creation endpoint. Below are the key changes:
Test file removal:
client/daemon/peer/piece_dispatcher_test.gowas entirely removed. This file contained extensive test code for thePieceDispatcherfunctionality, including helper classes, test cases, and concurrency logic.Middleware addition:
manager/router/router.go, a rate limiter middleware (middlewares.CreateJobRateLimiter) was added to thePOSTendpoint for job creation (/jobs). This change aims to control the rate of job creation requests.Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist