Feat/handler error handling and docs#4095
Feat/handler error handling and docs#4095retr0-kernel wants to merge 2 commits intodragonflyoss:mainfrom
Conversation
Signed-off-by: Krish Srivastava <krish22092003@gmail.com>
Signed-off-by: Krish Srivastava <krish22092003@gmail.com>
e028400 to
a8f7bd8
Compare
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (33.17%) is below the target coverage (34.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4095 +/- ##
==========================================
- Coverage 34.36% 33.17% -1.19%
==========================================
Files 346 346
Lines 40489 40625 +136
==========================================
- Hits 13913 13478 -435
- Misses 25660 26248 +588
+ Partials 916 899 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@gaius-qi I guess we need to re-run the jobs not sure what are the errors for the second job (which is a required one) |
| return | ||
| } | ||
|
|
||
| // Validate pagination parameters |
There was a problem hiding this comment.
The parameter verification has been completed in the annotation, refer to https://github.com/dragonflyoss/dragonfly/blob/main/manager/types/audit.go#L40.
| } | ||
|
|
||
| // Validate pagination parameters | ||
| if query.Page < 0 { |
There was a problem hiding this comment.
The parameter verification has been completed in the annotation, refer to https://github.com/dragonflyoss/dragonfly/blob/main/manager/types/audit.go#L40.
Description
application.go,audit.go)Related Issue
Closes #4094
Motivation and Context
These changes improve API robustness, make error responses more predictable, and help new contributors understand and follow best practices.
Screenshots (if appropriate)
N/A
Types of changes
Checklist