Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4103 +/- ##
==========================================
- Coverage 33.19% 33.17% -0.02%
==========================================
Files 346 346
Lines 40656 40656
==========================================
- Hits 13494 13487 -7
- Misses 26269 26275 +6
- Partials 893 894 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
yxxhero
previously approved these changes
May 29, 2025
CormickKneey
previously approved these changes
May 29, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
9065803
bf5116d to
9065803
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates submodule references and modifies logging configuration in deployment templates. The most important changes include updating submodules to newer commits and replacing the
verboselogging option withconsolein Docker Compose templates.Submodule updates:
client-rs: Updated submodule commit reference to44d58fee37e0c4d30bfce1976e199330fe22e51a.deploy/helm-charts: Updated submodule commit reference to8aceed5453d2b7ad2656f10f1b06cca3e45c0e97.Logging configuration changes:
deploy/docker-compose/template/client.template.yaml: Replacedverbose: truewithconsole: truefor logging to stdout.deploy/docker-compose/template/seed-client.template.yaml: Replacedverbose: truewithconsole: truefor logging to stdout.Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist