Skip to content

Add support for FreeBSD#4686

Open
jonakeys wants to merge 3 commits intodragonflyoss:mainfrom
jonakeys:freebsd_support
Open

Add support for FreeBSD#4686
jonakeys wants to merge 3 commits intodragonflyoss:mainfrom
jonakeys:freebsd_support

Conversation

@jonakeys
Copy link
Copy Markdown

Description

Adding support for compiling and running on FreeBSD (in addition to Linux and MacOS).

Related Issue

#4685

Motivation and Context

It solves the problem that compiling on FreeBSD doesn't work.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jonakeys jonakeys requested a review from a team as a code owner March 29, 2026 20:01
@jonakeys jonakeys marked this pull request as draft March 29, 2026 20:07
@gaius-qi gaius-qi added the enhancement New feature or request label Mar 30, 2026
@gaius-qi gaius-qi added this to the v2.5.0 milestone Mar 30, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.12%. Comparing base (2aab22a) to head (61b0432).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4686   +/-   ##
=======================================
  Coverage   28.12%   28.12%           
=======================================
  Files         232      232           
  Lines       23097    23097           
=======================================
  Hits         6495     6495           
  Misses      16161    16161           
  Partials      441      441           
Flag Coverage Δ
unittests 28.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi
Copy link
Copy Markdown
Member

@jonakeys Please rebase main.

@mingcheng
Copy link
Copy Markdown
Member

Hi, @jonakeys, thank you for your contribution. I also think you should update and add the GitHub action for the FreeBSD platform tests.

@jonakeys
Copy link
Copy Markdown
Author

Hi, @jonakeys, thank you for your contribution. I also think you should update and add the GitHub action for the FreeBSD platform tests.

That's right. I will look into that, fix/add them to this request.

@jonakeys jonakeys marked this pull request as ready for review March 30, 2026 19:40
@jonakeys jonakeys requested a review from a team as a code owner March 30, 2026 19:40
Comment thread .github/CODEOWNERS
Signed-off-by: Jonathan van der Steege <jonathan@jonakeys.nl>
Signed-off-by: Jonathan van der Steege <jonathan@jonakeys.nl>
Signed-off-by: Jonathan van der Steege <jonathan@jonakeys.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants