ci: add Docker credentials env vars and skip test if not set#4687
Merged
ci: add Docker credentials env vars and skip test if not set#4687
Conversation
Signed-off-by: Gaius <gaius.qi@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4687 +/- ##
==========================================
- Coverage 28.66% 28.12% -0.55%
==========================================
Files 232 232
Lines 23097 23097
==========================================
- Hits 6620 6495 -125
- Misses 16015 16161 +146
+ Partials 462 441 -21
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jonakeys
pushed a commit
to jonakeys/dragonfly
that referenced
this pull request
Mar 30, 2026
…lyoss#4687) Signed-off-by: Gaius <gaius.qi@gmail.com> Signed-off-by: Jonathan van der Steege <jonathan@jonakeys.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves the way Docker credentials are handled in both the CI workflow and the image preheat unit tests. The main changes ensure that Docker Hub credentials are securely passed to the test environment and that tests requiring authentication are skipped if credentials are missing.
CI/CD and Testing Improvements:
The CI workflow (
.github/workflows/ci.yml) now setsDOCKER_USERNAMEandDOCKER_PASSWORDenvironment variables for the unit test step, allowing tests to authenticate with Docker Hub.The image preheat unit test (
internal/job/image_test.go) now reads Docker credentials from environment variables and skips tests if they are not set, preventing authentication errors in environments without secrets configured.The
ManifestRequestobjects in the test cases are updated to include the Docker credentials, enabling authenticated requests to Docker Hub during testing. [1] [2]Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist