Skip to content

refactor(job): rename blobsURL to blobURL for grammatical accuracy#4708

Merged
gaius-qi merged 1 commit intomainfrom
feature/blob
Apr 10, 2026
Merged

refactor(job): rename blobsURL to blobURL for grammatical accuracy#4708
gaius-qi merged 1 commit intomainfrom
feature/blob

Conversation

@gaius-qi
Copy link
Copy Markdown
Member

@gaius-qi gaius-qi commented Apr 9, 2026

Description

This pull request makes a minor update to the internal/job/image.go file, focusing on improving naming consistency. The method previously named blobsURL has been renamed to blobURL, and all usages have been updated accordingly. This change helps clarify that the method returns the URL for a single blob, not multiple blobs.

  • Naming consistency:
    • Renamed the blobsURL method to blobURL in the preheatImage struct and updated all references to use the new name. [1] [2]

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.5.0 milestone Apr 9, 2026
@gaius-qi gaius-qi self-assigned this Apr 9, 2026
@gaius-qi gaius-qi requested a review from a team as a code owner April 9, 2026 09:53
@gaius-qi gaius-qi added the enhancement New feature or request label Apr 9, 2026
@gaius-qi gaius-qi requested a review from a team as a code owner April 9, 2026 09:53
@gaius-qi gaius-qi enabled auto-merge (squash) April 9, 2026 09:53
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.12%. Comparing base (9f7c81c) to head (8be7e9f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/job/image.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4708   +/-   ##
=======================================
  Coverage   28.12%   28.12%           
=======================================
  Files         232      232           
  Lines       23097    23097           
=======================================
  Hits         6495     6495           
  Misses      16161    16161           
  Partials      441      441           
Flag Coverage Δ
unittests 28.12% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/job/image.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit c3913e2 into main Apr 10, 2026
19 checks passed
@gaius-qi gaius-qi deleted the feature/blob branch April 10, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants