fix(manager): redact secrets from job responses - #4828
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4828 +/- ##
==========================================
+ Coverage 28.08% 28.17% +0.09%
==========================================
Files 232 233 +1
Lines 23153 23189 +36
==========================================
+ Hits 6502 6534 +32
- Misses 16211 16213 +2
- Partials 440 442 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: immanuwell <pchpr.00@list.ru>
10e62dc to
2340693
Compare
|
looked through the diff — clean separation putting the sanitization in its own file. couple things i noticed:
also the sanitize functions strip the keys entirely rather than replacing with tests look solid, good coverage of the nested object_storage and hdfs cases. |
Description
Preheat job responses leak creds back in
args. Kinda rough.This strips
password,headers, object storage secrets, and hdfs delegation tokens from create, get, list, and update job responses.Related Issue
N/A. Same leak pattern is already visible in public reports like #3226 and #3928.
Motivation and Context
Repro:
POST /oapi/v1/jobswith apreheatjob that includes private registry creds, request headers, object storage creds, or an hdfs delegation token.GET /oapi/v1/jobs/{id}orGET /oapi/v1/jobs.args.The job still runs with the original data. This only stops sending secrets back to API clients.
Screenshots (if appropriate)
Types of changes
Checklist