storage: fix flaky test #1825
Merged
storage: fix flaky test #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UT sometimes fails with: thread 'cache::worker::tests::test_worker_mgr_rate_limiter' (18435) panicked at storage/src/cache/worker.rs:512:9: assertion failed: mgr.prefetch_inflight.load(Ordering::Acquire) <= 2 test cache::worker::tests::test_worker_mgr_rate_limiter ... FAILED The check for intermediate inflight request is not really necessary and unreliable. Let's just drop it. Signed-off-by: Peng Tao <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1825 +/- ##
==========================================
- Coverage 56.46% 56.43% -0.04%
==========================================
Files 199 199
Lines 52048 52046 -2
Branches 44851 44849 -2
==========================================
- Hits 29388 29370 -18
- Misses 21176 21191 +15
- Partials 1484 1485 +1
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UT sometimes fails with:
thread 'cache::worker::tests::test_worker_mgr_rate_limiter' (18435) panicked at storage/src/cache/worker.rs:512:9: assertion failed: mgr.prefetch_inflight.load(Ordering::Acquire) <= 2 test cache::worker::tests::test_worker_mgr_rate_limiter ... FAILED
The check for intermediate inflight request is not really necessary and unreliable. Let's just drop it.