fix: prevent macOS shutdown blocking when tray icon is active - #68
Open
DesmondSylin wants to merge 1 commit into
Open
DesmondSylin wants to merge 1 commit into
DesmondSylin wants to merge 1 commit into
Conversation
Added proper handling of app quit events to prevent blocking system shutdown on macOS. When the system initiates shutdown, the app now correctly allows windows to close instead of intercepting the close event and hiding them to the tray. Changes: - Added isQuitting flag to track app quit state - Modified onWindowClose to allow closing during quit - Modified onWindowUnload to skip interception during quit - Added before-quit event listener to set flag and cleanup This fix ensures that when users shut down their Mac, Obsidian will properly exit even when running in background with tray icon, resolving the issue where shutdown would hang waiting for the app.
yurifrl
added a commit
to yurifrl/obsidian-tray
that referenced
this pull request
Jul 11, 2026
- dragonwocky#58: second-instance handler reveals hidden window instead of opening vault picker (fixes can't-reopen-after-close) - dragonwocky#35: stash native Tray on globalThis so plugin reload destroys the orphaned icon instead of duplicating it - dragonwocky#64: skip beforeunload hide for in-app link navigation - dragonwocky#68: isQuitting flag lets windows close during macOS shutdown - dragonwocky#76: dock transition queue + new "Auto hide taskbar icon" option plus 2s reconciliation interval (fixes dock icon stuck on rapid toggle) - dragonwocky#61: obsidian://tray/toggleWindows URI handler for Linux/Wayland
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added proper handling of app quit events to prevent blocking system shutdown on macOS. When the system initiates shutdown, the app now correctly allows windows to close instead of intercepting the close event and hiding them to the tray.
Changes:
This fix ensures that when users shut down their Mac, Obsidian will properly exit even when running in background with tray icon, resolving the issue where shutdown would hang waiting for the app.