Launcher fixes #1392
Open
Launcher fixes #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
launcher scripts - fixed and adjusted all launcher scripts helperFunctions, emulatorInit() - fixed errors (if conditions) - added functionality for searching emu executables (arguments and logic) - properly extract params array (launcher command arguments) - property add netplayCMD to launch args - handle RPCS3 and ShadPS4 desktop files - handle prlimit for yuzu and co
SilentException
force-pushed
the
dev-launchers-fix2
branch
from
6e8a030 to
0d82fb6
Compare
|
@SilentException Wow, thanks! Great PR, I ended up reverting the launcher changes since well, everything was broken as you said. Will come back to this in the future and merge it |
|
is this the new way launchers will work ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits 3b2393e, 6ada7cb, 10f9f53, c9e3f64 on dev branch basically broke all launchers.
This aims to fix it.
launcher scripts
helperFunctions, emulatorInit()
┆Issue is synchronized with this Trello card by Unito