Skip to content

Fix Citron command line arguments handling#1464

Merged
dragoonDorise merged 2 commits intodragoonDorise:devfrom
felipecrs:fix-citron-cli
May 24, 2025
Merged

Fix Citron command line arguments handling#1464
dragoonDorise merged 2 commits intodragoonDorise:devfrom
felipecrs:fix-citron-cli

Conversation

@felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Apr 22, 2025

I wanted to pass -u 2 (to launch Citron with user 2), and noticed the flag was not being passed properly to the Citron executable.

I know a thing or two about Bash and noticed the Citron launcher script could use some improvement while also fixing this issue.

  • Fix arguments being wrongly grouped after first " preventing other arguments like -u from working
  • Pass -f -g flags from Steam ROM Manager to align with other emulators, rather than implicitly from Citron launcher script
  • Optimize the Citron and Suyu launcher script, and remove unnecessary code
  • Refactor all legacy "'${filePath}'" to "${filePath}" (all launchers are already prepared to handle it properly)

@felipecrs
Copy link
Contributor Author

felipecrs commented Apr 22, 2025

@dragoonDorise, I have verified these changes to be working in my own Steam Deck. In my opinion this PR is a no-brainer, but I'm happy to clarify each change if you want.

@felipecrs
Copy link
Contributor Author

@dragoonDorise I rebased this PR, can you please review and merge it? 😭

@dragoonDorise dragoonDorise changed the base branch from main to dev May 16, 2025 18:32
@dragoonDorise dragoonDorise merged commit ccbaa86 into dragoonDorise:dev May 24, 2025
1 check passed
@felipecrs
Copy link
Contributor Author

Thanks so much!

@felipecrs felipecrs deleted the fix-citron-cli branch May 24, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments