Fix Citron command line arguments handling#1464
Merged
dragoonDorise merged 2 commits intodragoonDorise:devfrom May 24, 2025
felipecrs:fix-citron-cli
Merged
Fix Citron command line arguments handling#1464dragoonDorise merged 2 commits intodragoonDorise:devfrom felipecrs:fix-citron-cli
dragoonDorise merged 2 commits intodragoonDorise:devfrom
felipecrs:fix-citron-cli
Conversation
Contributor
Author
|
@dragoonDorise, I have verified these changes to be working in my own Steam Deck. In my opinion this PR is a no-brainer, but I'm happy to clarify each change if you want. |
Closed
4 tasks
Contributor
Author
|
@dragoonDorise I rebased this PR, can you please review and merge it? 😭 |
Contributor
Author
|
Thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to pass
-u 2(to launch Citron with user 2), and noticed the flag was not being passed properly to the Citron executable.I know a thing or two about Bash and noticed the Citron launcher script could use some improvement while also fixing this issue.
"preventing other arguments like-ufrom working-f -gflags from Steam ROM Manager to align with other emulators, rather than implicitly from Citron launcher script"'${filePath}'"to"${filePath}"(all launchers are already prepared to handle it properly)