Skip to content

Fix Citron command line arguments handling #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

felipecrs
Copy link

@felipecrs felipecrs commented Apr 22, 2025

I wanted to pass -u 2 (to launch Citron with user 2), and noticed the flag was not being passed properly to the Citron executable.

I know a thing or two about Bash and noticed the Citron launcher script could use some improvement while also fixing this issue.

  • Fix arguments being wrongly grouped after first " preventing other arguments like -u from working
  • Pass -f -g flags from Steam ROM Manager to align with other emulators, rather than implicitly from Citron launcher script
  • Optimize the Citron and Suyu launcher script, and remove unnecessary code
  • Refactor all legacy "'${filePath}'" to "${filePath}" (all launchers are already prepared to handle it properly)

@felipecrs
Copy link
Author

felipecrs commented Apr 22, 2025

@dragoonDorise, I have verified these changes to be working in my own Steam Deck. In my opinion this PR is a no-brainer, but I'm happy to clarify each change if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant