-
Notifications
You must be signed in to change notification settings - Fork 10
Docs for Ingress support #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Should we add a paragraph to the AKS & EKS install guides to show how to setup with the Azure Application Gateway for AKS and the AWS Load Balancer Controller for EKS?
Yep, I actually spent quite a bit of time configuring our CLI to use Azure Application Gateway (we had to use this in order to access the URLs without using VPN). Will add this part soon. I haven't experimented with the AWS stuff yet. Will work on it this afternoon and add the docs for it as well |
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces comprehensive documentation for Drasi's Ingress support functionality. The documentation covers how to deploy and manage Kubernetes ingress resources for Drasi Sources and Reactions through the CLI.
Key changes include:
- Added complete ingress initialization and configuration documentation
- Updated CLI reference to include the new
drasi ingress
command - Modified reaction configuration guides to reference ingress documentation instead of hardcoded endpoint configurations
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
docs/shared-content/ingress/ingress-init.md | New shared content file documenting ingress initialization commands and examples |
docs/content/reference/ingress/_index.md | New comprehensive ingress reference documentation covering multiple cloud providers and local setups |
docs/content/reference/command-line-interface/_index.md | Updated CLI reference to document the new drasi ingress command and subcommands |
docs/content/how-to-guides/configure-reactions/configure-signalr-reaction/_index.md | Updated to reference ingress documentation instead of hardcoded endpoint configuration |
docs/content/how-to-guides/configure-reactions/configure-drasi-result-reaction/_index.md | Removed hardcoded endpoint configuration and added ingress documentation reference |
docs/content/how-to-guides/configure-reactions/configure-drasi-debug-reaction/_index.md | Removed hardcoded endpoint configuration and added ingress documentation reference |
.github/config/en-custom.txt | Added new technical terms to the custom dictionary for spell checking |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
No description provided.