Skip to content

Conversation

ruokun-niu
Copy link
Contributor

No description provided.

Signed-off-by: ruokun-niu <[email protected]>
Copy link
Contributor

@danielgerlag danielgerlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we add a paragraph to the AKS & EKS install guides to show how to setup with the Azure Application Gateway for AKS and the AWS Load Balancer Controller for EKS?

@ruokun-niu
Copy link
Contributor Author

Looks good. Should we add a paragraph to the AKS & EKS install guides to show how to setup with the Azure Application Gateway for AKS and the AWS Load Balancer Controller for EKS?

Yep, I actually spent quite a bit of time configuring our CLI to use Azure Application Gateway (we had to use this in order to access the URLs without using VPN). Will add this part soon.

I haven't experimented with the AWS stuff yet. Will work on it this afternoon and add the docs for it as well

Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces comprehensive documentation for Drasi's Ingress support functionality. The documentation covers how to deploy and manage Kubernetes ingress resources for Drasi Sources and Reactions through the CLI.

Key changes include:

  • Added complete ingress initialization and configuration documentation
  • Updated CLI reference to include the new drasi ingress command
  • Modified reaction configuration guides to reference ingress documentation instead of hardcoded endpoint configurations

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
docs/shared-content/ingress/ingress-init.md New shared content file documenting ingress initialization commands and examples
docs/content/reference/ingress/_index.md New comprehensive ingress reference documentation covering multiple cloud providers and local setups
docs/content/reference/command-line-interface/_index.md Updated CLI reference to document the new drasi ingress command and subcommands
docs/content/how-to-guides/configure-reactions/configure-signalr-reaction/_index.md Updated to reference ingress documentation instead of hardcoded endpoint configuration
docs/content/how-to-guides/configure-reactions/configure-drasi-result-reaction/_index.md Removed hardcoded endpoint configuration and added ingress documentation reference
docs/content/how-to-guides/configure-reactions/configure-drasi-debug-reaction/_index.md Removed hardcoded endpoint configuration and added ingress documentation reference
.github/config/en-custom.txt Added new technical terms to the custom dictionary for spell checking

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ruokun-niu ruokun-niu merged commit c61d4e2 into drasi-project:main Sep 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants