Skip to content

fix: update Rust version in debug Dockerfiles and fix docs #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2025
+8 −8
Merged

fix: update Rust version in debug Dockerfiles and fix docs #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79d5998
fix: update Rust version in debug Dockerfiles and fix docs
whiz-Tuhin Sep 28, 2025
8296b4c
Merge branch 'main' into fix/dockerfile-debug-rust-version
danielgerlag Oct 1, 2025
085de9d
Merge branch 'main' into fix/dockerfile-debug-rust-version
danielgerlag Oct 8, 2025
a770c05
Merge branch 'main' into fix/dockerfile-debug-rust-version
danielgerlag Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/instructions/control-planes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ control-planes/
make docker-build

# Debug builds with shell access
make docker-build-debug
make docker-build BUILD_CONFIG=debug

# Build specific component
make -C mgmt_api docker-build
Expand Down
2 changes: 1 addition & 1 deletion .github/instructions/query-container.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ query-container/
make docker-build

# Build debug versions
make docker-build-debug
make docker-build BUILD_CONFIG=debug

# Build specific service
make -C publish-api docker-build
Expand Down
2 changes: 1 addition & 1 deletion control-planes/kubernetes_provider/Dockerfile.debug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM rust@sha256:8fae3b1a63a4dcfb6cf277a49fb5967ccbf479b9e9cee4588a077a9cb216e6d4 as builder
FROM rust:1.86-bullseye as builder
# rust:1.81-bullseye
RUN apt-get update && apt-get install -y protobuf-compiler cmake libc6-dev libssl-dev libclang-dev

Expand Down
2 changes: 1 addition & 1 deletion control-planes/mgmt_api/Dockerfile.debug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM rust@sha256:8fae3b1a63a4dcfb6cf277a49fb5967ccbf479b9e9cee4588a077a9cb216e6d4 as builder
FROM rust:1.86-bullseye as builder
# rust:1.81-bullseye
RUN apt-get update && apt-get install -y protobuf-compiler cmake libc6-dev libssl-dev libclang-dev

Expand Down
4 changes: 2 additions & 2 deletions docs/contributing/contributing-code/contributing-code-building/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ If you wish to override the default (latest) image tag, you can use the `DOCKER_
make docker-build DOCKER_TAG_VERSION="v1"
```

If you wish to build images that support opening a terminal, you can use the `docker-build-debug` target to build the images.
If you wish to build images that support opening a terminal, you can use the `docker-build BUILD_CONFIG=debug` target to build the images.
```sh
make docker-build-debug
make docker-build BUILD_CONFIG=debug
```

If you are using Kind in your development workflow, you can load the built images to your kind cluster using the `kind-load` target:
Expand Down
2 changes: 1 addition & 1 deletion sources/kubernetes/kubernetes-proxy/Dockerfile.debug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM rust@sha256:8fae3b1a63a4dcfb6cf277a49fb5967ccbf479b9e9cee4588a077a9cb216e6d4 as builder
FROM rust:1.86-bullseye as builder
# rust:1.81-bullseye
RUN apt-get update && apt-get install -y protobuf-compiler libcurl4 && apt-get clean

Expand Down
2 changes: 1 addition & 1 deletion sources/kubernetes/kubernetes-reactivator/Dockerfile.debug
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM rust@sha256:8fae3b1a63a4dcfb6cf277a49fb5967ccbf479b9e9cee4588a077a9cb216e6d4 as builder
FROM rust:1.86-bullseye as builder
# rust:1.81-bullseye
RUN apt-get update && apt-get install -y protobuf-compiler libcurl4 && apt-get clean

Expand Down
Loading