Fix Ingress / Failing e2e tests #322
Merged
+70
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Gerlag <[email protected]>
Signed-off-by: Daniel Gerlag <[email protected]>
Signed-off-by: Daniel Gerlag <[email protected]>
Signed-off-by: Daniel Gerlag <[email protected]>
Signed-off-by: Daniel Gerlag <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Format: {reaction-name}.drasi.{ip}.nip.io | ||
| // For local testing with kind, we can use localhost | ||
| this.hostname = `${this.reactionName}.drasi.localhost`; | ||
| this.hostname = `${this.reactionManifest.name}.drasi.localhost`; |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
|
|
||
| console.log(`IngressFixture: Using localhost access on port ${this.localPort}`); | ||
| console.log(`IngressFixture: Using hostname: ${this.hostname}`); | ||
| console.log(`SignalRFixture: Using localhost access on port ${this.localPort}`); |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
Signed-off-by: Daniel Gerlag <[email protected]>
Signed-off-by: Daniel Gerlag <[email protected]>
danielgerlag
changed the title
danielgerlag
requested review from
agentofreality,
amansinghoriginal and
ruokun-niu
amansinghoriginal
approved these changes
Oct 7, 2025
agentofreality
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple issues
Bitnami deprecation
https://thenewstack.io/broadcom-ends-free-bitnami-images-forcing-users-to-find-alternatives/
Bitnami, long known for providing free, production-ready Helm charts and container images for popular open-source applications, has recently changed its distribution model under Broadcom. Historically, Bitnami offered regularly updated, vulnerability-scanned images and maintained Helm charts at no cost, making it a staple in the Kubernetes ecosystem. Starting in late 2025, most versioned images are being moved to a “Bitnami Legacy” repository with no further updates, while only a limited set of “latest” tags will remain free for community and development use. Continued access to fully supported, versioned, and hardened images now requires a paid subscription to “Bitnami Secure Images.” As a result, users depending on free Bitnami images or Helm charts must update their configurations, migrate to alternative repositories, or adopt paid plans to maintain security and stability in production environments.
my-app images
The drasidemo container registry was deleted as part of an S360 cleanup, this broke the Kubernetes tests
Flakey handling of reactions
The e2e tests reused reaction names across tests, which can cause them to be flakey depending which order tests are executed, because there is a lag time in tearing down the resources.