Skip to content

fix: Set unique ingress hostnames for local Kind clusters #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 15, 2025
+35 −20
Merged

fix: Set unique ingress hostnames for local Kind clusters #326

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cd3f506
Updated CLI host
ruokun-niu Oct 13, 2025
7c43a79
nit
ruokun-niu Oct 13, 2025
80ef254
test fix;
ruokun-niu Oct 13, 2025
a7d0e15
test fix;
ruokun-niu Oct 13, 2025
fa53e23
updated host logic
ruokun-niu Oct 13, 2025
a2c5f52
updated contour annotation and k8s reconciler logic for ip replacement
ruokun-niu Oct 14, 2025
bcc6d2e
cargo fmt
ruokun-niu Oct 14, 2025
f6bcdb5
Merge branch 'main' into ingress-host-fix
danielgerlag Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions cli/cmd/ingress.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,23 @@

// Get configuration from the installer
installerConfig := ingressInstaller.GetIngressConfig()
config := &sdk.IngressConfig{
IngressClassName: installerConfig.ClassName,
IngressService: installerConfig.ServiceName,
IngressNamespace: installerConfig.Namespace,
GatewayIPAddress: "",
IngressAnnotations: annotationsMap, // Include annotations for Contour too
var config *sdk.IngressConfig
if localCluster {
config = &sdk.IngressConfig{
IngressClassName: installerConfig.ClassName,
IngressService: installerConfig.ServiceName,
IngressNamespace: installerConfig.Namespace,
GatewayIPAddress: "127.0.0.1",

Check notice

Code scanning / devskim

Accessing localhost could indicate debug code, or could hinder scaling. Note

Do not leave debug code in production
IngressAnnotations: annotationsMap, // Include annotations for Contour too
}
} else {
config = &sdk.IngressConfig{
IngressClassName: installerConfig.ClassName,
IngressService: installerConfig.ServiceName,
IngressNamespace: installerConfig.Namespace,
GatewayIPAddress: "",
IngressAnnotations: annotationsMap, // Include annotations for Contour too
}
}
if err := k8sPlatformClient.UpdateIngressConfig(config, output); err != nil {
return err
Expand Down
4 changes: 2 additions & 2 deletions control-planes/kubernetes_provider/src/controller/reconciler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@
}
}
None
}

Check notice

Code scanning / devskim

Accessing localhost could indicate debug code, or could hinder scaling. Note

Do not leave debug code in production

async fn reconcile_ingresses(&mut self) -> Result<(), Box<dyn std::error::Error>> {
if let Some(ingresses) = &self.spec.ingresses {
Expand All @@ -569,8 +569,8 @@
let ip_suffix = match self.get_ingress_external_ip().await {
Some(ip) => format!("{}.nip.io", ip),
None => {
log::warn!("Could not determine external IP, using UNAVAILABLE");
"UNAVAILABLE".to_string()
log::warn!("Could not determine external IP, using localhost");
"localhost".to_string()
}
};

Expand Down
8 changes: 4 additions & 4 deletions e2e-tests/fixtures/signalr-fixture.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@
this.localPort = parseInt(process.env.INGRESS_PORT) || 8001;

// Generate the hostname that the ingress expects
// Format: {reaction-name}.drasi.{ip}.nip.io
// For local testing with kind, we can use localhost
this.hostname = `${this.reactionManifest.name}.drasi.localhost`;
// Format: {reaction-name}.drasi.127.0.0.1.nip.io

Check notice

Code scanning / devskim

Accessing localhost could indicate debug code, or could hinder scaling. Note

Do not leave debug code in production
// This matches the format used by drasi ingress init --local-cluster
this.hostname = `${this.reactionManifest.name}.drasi.127.0.0.1.nip.io`;

Check notice

Code scanning / devskim

Accessing localhost could indicate debug code, or could hinder scaling. Note

Do not leave debug code in production

console.log(`SignalRFixture: Using localhost access on port ${this.localPort}`);
console.log(`SignalRFixture: Using ingress access on port ${this.localPort}`);
console.log(`SignalRFixture: Using hostname: ${this.hostname}`);

// Initialize SignalR connection through ingress
Expand Down
3 changes: 1 addition & 2 deletions e2e-tests/kind-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
- role: worker
extraPortMappings:
- containerPort: 30080 # Maps to contour-envoy NodePort 30080
hostPort: 8001
listenAddress: "0.0.0.0"
- containerPort: 30443 # Maps to contour-envoy NodePort 30443
- containerPort: 30443 # Maps to contour-envoy NodePort 30443
hostPort: 443
listenAddress: "0.0.0.0"
Loading