Skip to content

Conversation

ruokun-niu
Copy link
Contributor

  • Resolved all warnings in the test service
  • Add a pre-commit hook for running cargo fmt
  • Added a lint-check make target for checking cargo fmt and cargo clippy
  • Added a GH workflow that checks the lint of the code

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR resolves build warnings in the test service and introduces linting infrastructure across the framework.

  • Reformats web API code to eliminate style and warning issues.
  • Adds lint-check Makefile targets and a pre-commit hook for cargo fmt.
  • Creates a GitHub Actions workflow to enforce formatting and linting on push and PRs.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

File Description
e2e-test-framework/test-service/src/web_api/sources.rs Reformatted routing calls and added trailing commas to fix warnings
e2e-test-framework/test-service/Makefile Added lint-check target to run cargo fmt and cargo clippy
.github/workflows/lint.yml New workflow to run formatting and lint checks on CI
README.md Added instructions for enabling Git hooks for code quality checks
Comments suppressed due to low confidence (3)

.github/workflows/lint.yml:45

  • [nitpick] Pinning the checkout action to a full commit SHA can make future updates harder; consider using a version tag like actions/checkout@v4 to follow non-breaking updates more easily.
        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

README.md:11

  • [nitpick] Consider adding instructions for running the new make lint-check target and referencing the GitHub Actions lint workflow to ensure contributors validate formatting and lint rules locally and in CI.
git config core.hooksPath .githooks

.github/workflows/lint.yml:74

  • The CI workflow runs lint checks but doesn't run tests; consider adding a cargo test step to ensure code changes are covered by the existing test suite.
            make lint-check

@ruokun-niu ruokun-niu merged commit 16ed64f into main Jul 9, 2025
6 checks passed
@ruokun-niu ruokun-niu deleted the build-warnings-and-lint-tools branch July 9, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants