-
Notifications
You must be signed in to change notification settings - Fork 3
E2e framework automation #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
Signed-off-by: ruokun-niu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces comprehensive end-to-end (E2E) testing automation for the "Building Comfort" scenario by adding new GitHub Actions workflows, Azure infrastructure templates, and updating existing release workflows to support external automation triggers.
- Adds a complete E2E testing workflow that provisions AKS clusters, runs tests, and uploads results to Azure Storage
- Introduces Azure Bicep template for automated AKS cluster provisioning with configurable parameters
- Enhances the release workflow to support repository dispatch events for external automation triggers
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
.github/workflows/building-comfort.yml |
New E2E test workflow for building comfort scenario with AKS provisioning and test execution |
infra/aks/aks-cluster.bicep |
New Bicep template for automated AKS cluster creation with parameterized configuration |
.github/workflows/draft-release.yml |
Enhanced release workflow with repository dispatch support and dynamic environment variables |
e2e-test-framework/examples/building_comfort/drasi/get_test_run_results.sh |
Updated test result collection script to use correct path naming convention |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
||
|
||
# cleanup: | ||
# runs-on: ubuntu-latest | ||
# needs: deploy-tests | ||
# if: always() | ||
# strategy: | ||
# matrix: | ||
# cluster_type: [redis, rocks, memory] | ||
|
||
# steps: | ||
# - name: Azure Login | ||
# uses: azure/login@v2 | ||
# with: | ||
# client-id: ${{ secrets.AZURE_CLIENT_ID }} | ||
# tenant-id: ${{ secrets.AZURE_TENANT_ID }} | ||
# subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }} | ||
|
||
# - name: Delete AKS cluster | ||
# run: | | ||
# az aks delete \ | ||
# --resource-group ${{ env.RESOURCE_GROUP_NAME }} \ | ||
# --name "building-comfort-aks-${{ github.run_number }}-${{ matrix.cluster_type }}" \ | ||
# --yes --no-wait | ||
No newline at end of file |
Copilot
AI
Sep 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commented cleanup job should either be removed or uncommented with proper documentation explaining why it's disabled. Leaving commented code in production workflows reduces maintainability and creates confusion about intended behavior.
# cleanup: | |
# runs-on: ubuntu-latest | |
# needs: deploy-tests | |
# if: always() | |
# strategy: | |
# matrix: | |
# cluster_type: [redis, rocks, memory] | |
# steps: | |
# - name: Azure Login | |
# uses: azure/login@v2 | |
# with: | |
# client-id: ${{ secrets.AZURE_CLIENT_ID }} | |
# tenant-id: ${{ secrets.AZURE_TENANT_ID }} | |
# subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }} | |
# - name: Delete AKS cluster | |
# run: | | |
# az aks delete \ | |
# --resource-group ${{ env.RESOURCE_GROUP_NAME }} \ | |
# --name "building-comfort-aks-${{ github.run_number }}-${{ matrix.cluster_type }}" \ | |
# --yes --no-wait | |
Copilot uses AI. Check for mistakes.
push: | ||
branches: | ||
- e2e-framework-automation |
Copilot
AI
Sep 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow is configured to trigger on pushes to a feature branch 'e2e-framework-automation'. This should be updated to trigger on appropriate branches like 'main' or 'develop' for production use, or removed if this was only for development testing.
push: | |
branches: | |
- e2e-framework-automation | |
- main | |
- develop |
Copilot uses AI. Check for mistakes.
|
||
|
Copilot
AI
Sep 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty lines with trailing whitespace should be removed to maintain clean code formatting.
Copilot uses AI. Check for mistakes.
Signed-off-by: ruokun-niu <[email protected]>
This pull request introduces a new end-to-end (E2E) testing workflow for the "Building Comfort" scenario, adds supporting Azure infrastructure automation, and refines the release workflow for better flexibility and automation. It also updates test result collection scripts to align with current naming conventions.
CI/CD and Testing Automation
.github/workflows/building-comfort.yml
) to automate E2E testing for the "Building Comfort" scenario, including provisioning AKS clusters, running tests, exporting results, and uploading them to Azure Storage.infra/aks/aks-cluster.bicep
) to automate AKS cluster creation with configurable parameters for use in CI pipelines.Release Workflow Enhancements
.github/workflows/draft-release.yml
) to support triggering viarepository_dispatch
events, allowing external automation to initiate releases.Test Result Collection
e2e-test-framework/examples/building_comfort/drasi/get_test_run_results.sh
) to use the correctgithub_dev_repo
path instead of the deprecatedaz_dev_repo
, ensuring compatibility with the current test run naming conventions.