-
Notifications
You must be signed in to change notification settings - Fork 277
Updated PixiRenderer to v8 #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I am planning to use ParticleContainer |
added "particlecontainer" to usage |
…e optimizations for performance
Oh, thank you very much. merge it later. a bit busy now. |
I readded batching and caching and particlecontainer, it lags at around 50k particles, needs optimizing. |
I will reopen this PR from draft when I done with optimizations. I believe we can get more performance with more particles. |
critical issue; colors (and probably other behaviours too) uses old pooled particles too when using default particles, will fix soon |
I fixed the issue with using EmitterAwarePool; Store Emitter ID during the "onParticleCreated" method and store emitter ID directly on particle "particle.__emitterId" |
…up & enhanced error handling
Currently added features; Added new renderer options this.options = {
useParticleContainer: true,
autoResize: true,
scale: 1,
maxParticles: 10000,
properties: {
position: true,
rotation: true,
scale: true,
uvs: true,
alpha: true
},
...options
}; Now uses particle containers as default, Maintains compatibility with v7 by defaulting original behavior (WIP, not intended to work well) Added thorough cleanup for all resources (textures, containers) Improved error checking throughout the code |
I rewrote the whole code to figure-out whats wrong with emitters using old/deleted particles, I fixed it (magic idk how), and I tried to add full backwards comp. Will try to add performance fixes later but currently this handles particles well, but as always can be better |
Oh, I've been quite busy lately, so I may not be able to respond to you immediately. |
This is an early prototype, please use with caution.